Closed
Bug 788680
Opened 13 years ago
Closed 13 years ago
Don't stripped symbols from Nightly releases
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
696 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently we strip symbols (function names) from the nightly releases. This makes it impossible to profile them via eideticker.
Size differences (approximation, I compared my build with nightly) to using 'STRIP_FLAGS="--strip-debug"':
APK Size increase: 16.3MB to 18.8MB (+2.5MB)
Uncompressed APK Size increase: 29MB to 44MB (+15MB)
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #658597 -
Flags: review?(ted.mielczarek)
Attachment #658597 -
Flags: review?(blassey.bugs)
Comment 2•13 years ago
|
||
Comment on attachment 658597 [details] [diff] [review]
Patch
Review of attachment 658597 [details] [diff] [review]:
-----------------------------------------------------------------
Do you want this for armv6 nightlies too?
::: mobile/android/config/mozconfigs/android/nightly
@@ +24,5 @@
> # Use ccache
> ac_add_options --with-ccache=/usr/bin/ccache
> +
> +# This will overwrite the default of stripping everything and keep the symbol table.
> +# This is useful for profiling with eideticker. See bug 788680
Don't bother with the bug number, you can find that via hg blame.
Attachment #658597 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #2)
> Comment on attachment 658597 [details] [diff] [review]
> Patch
>
> Review of attachment 658597 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Do you want this for armv6 nightlies too?
>
I intentionally left out armv6 because I assume those device are under greater memory but the .symtab section isn't flagged PT_LOAD so it doesn't actually matter. I'll patch it when we add armv6 to eideticker.
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 658597 [details] [diff] [review]
Patch
One review is enough and I already discussed this with Brad on IRC
Attachment #658597 -
Flags: review?(blassey.bugs)
Assignee | ||
Comment 5•13 years ago
|
||
Target Milestone: --- → Firefox 18
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Product: Fennec Graveyard → Core
Target Milestone: Firefox 18 → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•