788680 - Don't stripped symbols from Nightly releases

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Benoit Girard (:BenWa)]

Currently we strip symbols (function names) from the nightly releases. This makes it impossible to profile them via eideticker.

Size differences (approximation, I compared my build with nightly) to using 'STRIP_FLAGS="--strip-debug"':
APK Size increase: 16.3MB to 18.8MB (+2.5MB)
Uncompressed APK Size increase: 29MB to 44MB (+15MB)

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 658597 [details] [diff] [review]
Patch

Review of attachment 658597 [details] [diff] [review]:
-----------------------------------------------------------------

Do you want this for armv6 nightlies too?

::: mobile/android/config/mozconfigs/android/nightly
@@ +24,5 @@
>  # Use ccache
>  ac_add_options --with-ccache=/usr/bin/ccache
> +
> +# This will overwrite the default of stripping everything and keep the symbol table.
> +# This is useful for profiling with eideticker. See bug 788680

Don't bother with the bug number, you can find that via hg blame.

Comment 3

[Benoit Girard (:BenWa)]

(In reply to Ted Mielczarek [:ted] from comment #2)
> Comment on attachment 658597 [details] [diff] [review]
> Patch
> 
> Review of attachment 658597 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Do you want this for armv6 nightlies too?
> 

I intentionally left out armv6 because I assume those device are under greater memory but the .symtab section isn't flagged PT_LOAD so it doesn't actually matter. I'll patch it when we add armv6 to eideticker.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 658597 [details] [diff] [review]
Patch

One review is enough and I already discussed this with Brad on IRC

Comment 5

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9235cf9dadaa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9235cf9dadaa