Closed
Bug 788681
Opened 14 years ago
Closed 14 years ago
Typedefs IOSurfaceGetWidthFunc and IOSurfaceGetHeightFunc swapped in QuartzSupport.mm
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: smichaud, Assigned: BenWa)
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/1948141f2eb0/gfx/2d/QuartzSupport.mm#l131
This is trivially easy to fix. But it's very odd that it wasn't noticed before.
|
Reporter | |
Comment 1•14 years ago
|
||
Oops, it wasn't the function pointers that were swapped -- just the functions' typedefs.
Which doesn't matter, since both functions have the same typedef.
Summary: Function pointers for IOSurfaceGetHeight and IOSurfaceGetWidth swapped in QuartzSupport.mm → Typedefs IOSurfaceGetWidthFunc and IOSurfaceGetHeightFunc swapped in QuartzSupport.mm
|
Assignee | |
Comment 2•14 years ago
|
||
The type are inverted but they are both the same type with a different name so it wouldn't cause a noticeable bug. Let's fix it anyways. Want me write up the patch?
|
|
Reporter | |
Comment 3•14 years ago
|
||
> Want me write up the patch?
Go ahead :-)
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
|
Reporter | |
Updated•14 years ago
|
Attachment #658602 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Target Milestone: --- → mozilla18
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•