Closed Bug 788681 Opened 10 years ago Closed 10 years ago
Get Width Func and IOSurface Get Height Func swapped in Quartz Support .mm
http://hg.mozilla.org/mozilla-central/annotate/1948141f2eb0/gfx/2d/QuartzSupport.mm#l131 This is trivially easy to fix. But it's very odd that it wasn't noticed before.
Oops, it wasn't the function pointers that were swapped -- just the functions' typedefs. Which doesn't matter, since both functions have the same typedef.
Summary: Function pointers for IOSurfaceGetHeight and IOSurfaceGetWidth swapped in QuartzSupport.mm → Typedefs IOSurfaceGetWidthFunc and IOSurfaceGetHeightFunc swapped in QuartzSupport.mm
The type are inverted but they are both the same type with a different name so it wouldn't cause a noticeable bug. Let's fix it anyways. Want me write up the patch?
> Want me write up the patch? Go ahead :-)
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #658602 - Flags: review?(smichaud)
Attachment #658602 - Flags: review?(smichaud) → review+
Target Milestone: --- → mozilla18
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.