788729 - nsDirectoryService.cpp:71:14: warning: variable 'rv' set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

GCC 4.7 (and probably earlier versions as well) build warning:
{
xpcom/io/nsDirectoryService.cpp:71:14: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix (also mark directory as warning-free)

I believe this is the last build warning in this directory, at least on my machine (with GCC 4.7).

So, I'm marking the directory as warning-free in this patch.

Comment 2

[Daniel Holbert [:dholbert]]

(You might notice that my added line in nsDirectoryService.cpp uses 4 spaces of indentation, vs. the code after it uses 2 spaces.  That 2-space block of code isn't the norm for this file -- the majority of the file uses 4 spaces, and the file's emacs modeline says 4 spaces.)

Comment 3

[Daniel Holbert [:dholbert]]

Turns out we can't mark this directory as warning-free yet -- Try showed that there was another build warning on OS X 10.8:

> io/nsLocalFileUnix.cpp:1613:13: error: 'lstat64' is deprecated [-Werror,-Wdeprecated-declarations]
https://tbpl.mozilla.org/php/getParsedLog.php?id=15088962&tree=Try

So I removed the Makefile.in FAIL_ON_WARNINGS tweak, and pushed just the nsDirectoryService warning fix.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3b341b36d42

Comment 4

[Daniel Holbert [:dholbert]]

> Try showed that there was another build warning on OS X 10.8:

er, 10.7 (but probably also 10.8)

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3b341b36d42