Closed Bug 788754 Opened 7 years ago Closed 7 years ago

Simplify SourceClient's API for its consumers

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 18

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

Attachments

(1 file)

v1
4.91 KB, patch
past
: review+
Details | Diff | Splinter Review 
They should just be able to get the source as a string and not have to worry about tokens or whether it was sent as a long string, etc.
Priority: -- → P3
Attached patch v1 — — Splinter Review 
Try push, please, Panos :)
Assignee: nobody → fitzgen
Status: NEW → ASSIGNED
Attachment #665914 - Flags: review?(past)
The Windows-only xpcshell test failures are also present in a try push without this patch, but with the patches from bug 755661.
Comment on attachment 665914 [details] [diff] [review]
v1

Review of attachment 665914 [details] [diff] [review]:
-----------------------------------------------------------------

Nice API polish!
Attachment #665914 - Flags: review?(past) → review+
https://hg.mozilla.org/mozilla-central/rev/d2850363666b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.