788933 - Secure HTML bugmail is still missing bug summary / subject

Status: RESOLVED FIXED

Description

[Jesse Ruderman]

Even after clicking the message in Thunderbird's message list, the subject is shown as "[Bug ______] (Secure bug ______ updated)".

This is with bugmail sent today, which should have the fix for bug 785219 deployed.

Comment 1

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7]

For me it was broken, got fixed, and then broke again sometime between 15:43 and 19:47 PDT today.

Comment 2

[Byron Jones ‹:glob› 🎈]

(In reply to Jesse Ruderman from comment #0)
> This is with bugmail sent today, which should have the fix for bug 785219
> deployed.

indeed -- bug 785219 only adds it to text/plain parts.

(In reply to David Baron [:dbaron] from comment #1)
> For me it was broken, got fixed, and then broke again sometime between 15:43
> and 19:47 PDT today.

no changes were made to bmo within that timeframe (the last code change was a week ago).

Comment 3

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7]

Then you have an intermittent bug in b.m.o.

I got bugmail from Bug 787089 at
Date: Thu, 06 Sep 2012 02:47:46 +0000
that had no Subject: in the encrypted text/plain part.

Comment 4

[Byron Jones ‹:glob› 🎈]

(In reply to David Baron [:dbaron] from comment #3)
> Then you have an intermittent bug in b.m.o.

can i get the X-Generated-By header from that message please, and also from one that included the subject if possible.

Comment 5

[Reed Loden [:reed] (use needinfo?)]

Had subject -- pp-app-bugs02.phx.mozilla.com/pp-app-bugs01.phx.mozilla.com(6783)

Missing subject -- pp-app-bugs02.phx.mozilla.com

Comment 6

[Byron Jones ‹:glob› 🎈]

thanks reed and dbaron.  i've raised bug 788948 to track that issue.

Comment 7

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7]

**without** subject:
Received: (from root@localhost)
        by pp-app-bugs01.phx.mozilla.com (8.13.8/8.13.8/Submit) id
        q862lpio028872;
        Wed, 5 Sep 2012 19:47:51 -0700
X-Generated-By: pp-app-bugs03.phx.mozilla.com

with subject:
Received: (from root@localhost)
        by pp-app-bugs02.phx.mozilla.com (8.13.8/8.13.8/Submit) id
        q85MhBoc021774;
        Wed, 5 Sep 2012 15:43:11 -0700
X-Generated-By:
pp-app-bugs03.phx.mozilla.com/pp-app-bugs02.phx.mozilla.com(12841)

with subject:
Received: (from root@localhost)
        by pp-app-bugs02.phx.mozilla.com (8.13.8/8.13.8/Submit) id
        q85MeuUm019670;
        Wed, 5 Sep 2012 15:40:56 -0700
X-Generated-By:
pp-app-bugs03.phx.mozilla.com/pp-app-bugs02.phx.mozilla.com(12864)

with subject:
Received: (from root@localhost)
        by pp-app-bugs01.phx.mozilla.com (8.13.8/8.13.8/Submit) id
        q85MHUnZ029994;
        Wed, 5 Sep 2012 15:17:30 -0700
X-Generated-By: pp-app-bugs03.phx.mozilla.com/pp-app-bugs01.phx.mozilla.com(6760)

Comment 8

[Byron Jones ‹:glob› 🎈]

(In reply to David Baron [:dbaron] from comment #7)
> **without** subject:
> Received: (from root@localhost)
>         by pp-app-bugs01.phx.mozilla.com (8.13.8/8.13.8/Submit) id
>         q862lpio028872;
>         Wed, 5 Sep 2012 19:47:51 -0700
> X-Generated-By: pp-app-bugs03.phx.mozilla.com

in bug 788948 fox2mike found a rogue process on pp-app-bugs01, which has been restarted.

Comment 9

[Byron Jones ‹:glob› 🎈]

Attachment: patch v1

Comment 10

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7]

While you're there, why are you using CRs (\015s) in the text/plain part?  The subject and the blank line after it are the only places in the text/plain part that have CRs.  (And in mutt, they show up as "^M".)

Comment 11

[Byron Jones ‹:glob› 🎈]

(In reply to David Baron [:dbaron] from comment #10)
> While you're there, why are you using CRs (\015s) in the text/plain part? 
> The subject and the blank line after it are the only places in the
> text/plain part that have CRs.  (And in mutt, they show up as "^M".)

i'm unable to reproduce this with mutt on linux, both with and without this patch.
mutt-1.5.21-7 gnupg2-2.0.18-2

when i decrypt messages on my mac and examine the line endings, they are consistent.

Comment 12

[David Lawrence [:dkl]]

Comment on attachment 658810 [details] [diff] [review]
patch v1

Review of attachment 658810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and works as expected. r=dkl

::: extensions/SecureMail/Extension.pm
@@ +523,5 @@
>  }
>  
> +# Insert the subject into the part's body, as the subject of the message will
> +# be sanitised.
> +# XXX this incorrectly assumes all parts of the message are the body

You could grep for "You are receiving this mail because" which is in both the HTML and text bodies always. But as this is not a regression since we were not doing this before, we can worry about it later.

Comment 13

[Byron Jones ‹:glob› 🎈]

(In reply to David Lawrence [:dkl] from comment #12)
> You could grep for "You are receiving this mail because" which is in both
> the HTML and text bodies always.

a safer way would be to only work on parts who's parent is multipart/alternative.  but as you say, that's fodder for later.

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/SecureMail/Extension.pm
Committed revision 8322.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/SecureMail/Extension.pm
Committed revision 8344.