rename nsIPresShell:InitialReflow to Initialize

RESOLVED FIXED in mozilla18

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I propose we rename nsIPresShell::InitialReflow to Initialize because:

 (1) no reflow is performed inside "InitialReflow".  Multiple times, this has led to confusion with people doing profiling, finding a lot of time was spent in a method called InitialReflow, and starting discussions about reflow being slow.  (If my memory is correct, it does frame construction and style resolution, including XBL binding handling, and then posts an event to do reflow later.)

 (2) "initial reflow" is an oxymoron.  (Maybe "initial flow" and "re-flow" would make sense.)
(Assignee)

Comment 1

5 years ago
Created attachment 658798 [details] [diff] [review]
patch

I've had this in my tree for ages.  (I just hit some conflicts today, so I was reminded.)
Attachment #658798 - Flags: review?(roc)
Attachment #658798 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3684a179853c

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3684a179853c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.