Closed Bug 788956 Opened 12 years ago Closed 12 years ago

rename nsIPresShell:InitialReflow to Initialize

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

I propose we rename nsIPresShell::InitialReflow to Initialize because:

 (1) no reflow is performed inside "InitialReflow".  Multiple times, this has led to confusion with people doing profiling, finding a lot of time was spent in a method called InitialReflow, and starting discussions about reflow being slow.  (If my memory is correct, it does frame construction and style resolution, including XBL binding handling, and then posts an event to do reflow later.)

 (2) "initial reflow" is an oxymoron.  (Maybe "initial flow" and "re-flow" would make sense.)
Attached patch patchSplinter Review
I've had this in my tree for ages.  (I just hit some conflicts today, so I was reminded.)
Attachment #658798 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/3684a179853c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: