789010 - Use the PageThumbs API to get tab previews for tabs that aren't loaded yet

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 658839 [details] [diff] [review]
patch

Review of attachment 658839 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-tabPreviews.js
@@ +50,5 @@
> +      return aTab.__thumbnail;
> +
> +    if (aTab.getAttribute("pending") == "true") {
> +      let img = new Image;
> +      img.src = PageThumbs.getThumbnailURL(aTab.linkedBrowser.currentURI.spec);

Nit: you could save currentURI.spec in a variable as we access it already at the top of the function.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/62aeb6b5db75

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/62aeb6b5db75

Comment 4

[Alex Keybl [:akeybl]]

QA - please verify that this fixes the STR in https://bugzilla.mozilla.org/show_bug.cgi?id=789037#c0

Comment 5

[Virgil Dicu [:virgil] [QA]]

(In reply to Alex Keybl [:akeybl] from comment #4)
> QA - please verify that this fixes the STR in
> https://bugzilla.mozilla.org/show_bug.cgi?id=789037#c0

Could anyone explain what the expected result would be here? I don't see a particular difference with the build from the report date (2012-09-05)
What I'm seeing with 18b1 after following the steps:
tab thumbnail previews are loaded for the majority of sites, but for what I can tell there still are cases (e.g. mozilla.ro) where an empty placeholder is left instead if the site isn't loaded in the session.

tested on Linux:Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/18.0 Firefox/18.0

Comment 6

[juan becerra [:juanb]]

Dão could you add a before and after behavior description to make sure we can verify this bug using the STR from bug 789037?

Comment 7

[Dão Gottwald [:dao]]

STR:

- set browser.ctrlTab.previews to true
- close Firefox with a couple of tabs open
- start Firefox and restore the previous session
- hit Ctrl+Tab

-> the Ctrl+Tab panel should show previews for background tabs even though they're not loaded yet

Comment 8

[Virgil Dicu [:virgil] [QA]]

Thanks. 

Verified on Ubuntu 12.04 and Windows 7 on Firefox 18 beta 2:
Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/20100101 Firefox/18.0

Previews on mac don't work (that's bug 727378).