789032 - Dragging a link over the tab strip's scroll arrows calls _getDropIndex unnecessarily

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 658859 [details] [diff] [review]
patch

Review of attachment 658859 [details] [diff] [review]:
-----------------------------------------------------------------

> var minMargin = scrollRect.left - rect.left;
> var maxMargin = Math.min(minMargin + scrollRect.width,
>                          scrollRect.right);
> if (!ltr)
>   [minMargin, maxMargin] = [this.clientWidth - maxMargin,
>                             this.clientWidth - minMargin];

minMargin and maxMargin are only referenced inside of the |if (pixelsToScroll)| block. Can you move these lines within that block (and switch to using |let| for these at the same time)?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #1)
> minMargin and maxMargin are only referenced inside of the |if
> (pixelsToScroll)| block. Can you move these lines within that block (and
> switch to using |let| for these at the same time)?

filed bug 789079 for this

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4fdce7d4f4b3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4fdce7d4f4b3