Closed
Bug 789053
Opened 14 years ago
Closed 14 years ago
Feed validator needs an encoded uri
Categories
(MailNews Core :: Feed Reader, defect)
MailNews Core
Feed Reader
Tracking
(thunderbird17 fixed, seamonkey2.14 fixed)
RESOLVED
FIXED
Thunderbird 18.0
People
(Reporter: alta88, Assigned: alta88)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #658877 -
Flags: review?(mconley)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 658877 [details] [diff] [review]
patch
Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks!
Bonus points if you follow this up with a test case...
Attachment #658877 -
Flags: review?(mconley) → review+
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 658877 [details] [diff] [review]
patch
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: the validation tool won't work with feed urls needing encoding.
Testing completed (on c-c, etc.): locally.
Risk to taking this patch (and alternatives if risky): possibly less than 0..
Attachment #658877 -
Flags: approval-comm-aurora?
|
||
Comment 5•13 years ago
|
||
Comment on attachment 658877 [details] [diff] [review]
patch
Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------
a+=me [flag notwithstanding]
|
|
||
Comment 6•13 years ago
|
||
status-seamonkey2.14:
--- → fixed
status-thunderbird17:
--- → fixed
|
||
Updated•13 years ago
|
Attachment #658877 -
Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•