The default bug view has changed. See this FAQ.

Feed validator needs an encoded uri

RESOLVED FIXED in Thunderbird 18.0

Status

MailNews Core
Feed Reader
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 18.0
Bug Flags:
in-testsuite ?

SeaMonkey Tracking Flags

(thunderbird17 fixed, seamonkey2.14 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 658877 [details] [diff] [review]
patch
Attachment #658877 - Flags: review?(mconley)
Comment on attachment 658877 [details] [diff] [review]
patch

Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Bonus points if you follow this up with a test case...
Attachment #658877 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/757e3706c5b1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
(Assignee)

Comment 4

5 years ago
Comment on attachment 658877 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined:  the validation tool won't work with feed urls needing encoding.
Testing completed (on c-c, etc.): locally.
Risk to taking this patch (and alternatives if risky): possibly less than 0..
Attachment #658877 - Flags: approval-comm-aurora?
Comment on attachment 658877 [details] [diff] [review]
patch

Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------

a+=me [flag notwithstanding]
http://hg.mozilla.org/releases/comm-aurora/rev/cb2115024fa9
status-seamonkey2.14: --- → fixed
status-thunderbird17: --- → fixed
Attachment #658877 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.