Closed Bug 789053 Opened 12 years ago Closed 12 years ago

Feed validator needs an encoded uri

Categories

(MailNews Core :: Feed Reader, defect)

Product:
MailNews Core
Component:
Feed Reader
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird17 fixed, seamonkey2.14 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 18.0
Tracking Flags:
Tracking Status
thunderbird17 --- fixed
seamonkey2.14 --- fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file)

patch
1.08 KB, patch
mconley
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch — — Splinter Review 

        Attachment #658877 -
        Flags: review?(mconley)

    
    

    
  
Comment on attachment 658877 [details] [diff] [review]
patch

Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Bonus points if you follow this up with a test case...

        Attachment #658877 -
        Flags: review?(mconley) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/757e3706c5b1
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0

    
    

    
  
Comment on attachment 658877 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined:  the validation tool won't work with feed urls needing encoding.
Testing completed (on c-c, etc.): locally.
Risk to taking this patch (and alternatives if risky): possibly less than 0..

        Attachment #658877 -
        Flags: approval-comm-aurora?

    
    

    
  
Comment on attachment 658877 [details] [diff] [review]
patch

Review of attachment 658877 [details] [diff] [review]:
-----------------------------------------------------------------

a+=me [flag notwithstanding]

        Attachment #658877 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: