Make B2G and Fennec browser actors inherit the extensibility API changes

RESOLVED FIXED in Firefox 18

Status

P2
normal
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 18
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The patch in bug 753401 allows add-ons to provide their own actors for the remote protocol. However this was tested and verified to work for desktop add-ons only, and B2G and Fennec add-ons need some more changes to work.
Created attachment 658924 [details] [diff] [review]
Patch v1

Trying to minimize changes to B2G and Fennec actors. glandium can you verify that this patch works for you in both cases?
Attachment #658924 - Flags: feedback?(mh+mozilla)
Comment on attachment 658924 [details] [diff] [review]
Patch v1

As said on irc, only tested on b2g, assuming the fennec part corresponds to the previous iteration (which, looking at the code, looks like is the case)
Attachment #658924 - Flags: feedback?(mh+mozilla) → feedback+
Created attachment 659727 [details] [diff] [review]
Patch v2

This is slightly better. If you can confirm it still works, I'll ask for reviews.
Attachment #658924 - Attachment is obsolete: true
Attachment #659727 - Flags: feedback?(mh+mozilla)
Comment on attachment 659727 [details] [diff] [review]
Patch v2

It works for me on Fennec (haven't checked B2G)
Attachment #659727 - Flags: feedback?(mh+mozilla) → feedback+
Comment on attachment 659727 [details] [diff] [review]
Patch v2

This patch allows dynamically-added actors to be usable via the remote debugging protocol for Fennec and B2G. For B2G I'm not sure if add-ons will be allowed (perhaps provided by the vendor, like what we do with PDF.js in desktop?), but the API is still useful regardless. The changes are pretty straight-forward.
Attachment #659727 - Flags: review?(mihai.sucan)
Attachment #659727 - Flags: review?(mark.finkle)
Attachment #659727 - Flags: review?(21)
Comment on attachment 659727 [details] [diff] [review]
Patch v2

The Fennec changes look fine
Attachment #659727 - Flags: review?(mark.finkle) → review+
Comment on attachment 659727 [details] [diff] [review]
Patch v2

Looks good.
Attachment #659727 - Flags: review?(mihai.sucan) → review+

Updated

6 years ago
Blocks: 751034
Depends on: 790952
Blocks: 790952
No longer depends on: 790952
https://hg.mozilla.org/mozilla-central/rev/642f820edff8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.