78912 - nsMsgPrintEngine::SetStatusMessage() is leaking a string.

Status: VERIFIED FIXED

(MailNews Core :: Printing, defect)

Description

[Judson Valeski]

nsresult
nsMsgPrintEngine::SetStatusMessage(PRUnichar *aMsgString)
{
  PRUnichar     *progressMsg;

  if ( (!mFeedback) || (!aMsgString) )
    return NS_OK;

  progressMsg = nsCRT::strdup(aMsgString);
  mFeedback->ShowStatusString(progressMsg);
  return NS_OK;
}

progressMsg is being leaked.

Comment 1

[Judson Valeski]

Attachment: diffs to get rid of PR_FREEIF usage, and prevent the leak.

Comment 2

[Scott MacGregor]

sr=mscottt....thanks jud.

Comment 3

[rpotts (gone)]

r=rpotts.

I bet that you could get rid of the strdup() and free() all together in
nsMsgPrintEngine::SetStatusMessage(...)

Comment 4

[Judson Valeski]

Attachment: mscott, can I get an sr on the updated patch. skips the alloc/free altogether.

Comment 5

[Scott MacGregor]

some rhp extra str duping..

looks good.
sr=mscott

Comment 6

[Judson Valeski]

fix is in. thanks.

Comment 7

[Judson Valeski]

this was checked in yesterday.

Comment 8

[esther]

I need test scerario to verify this, please!

Comment 9

[Scott MacGregor]

verified by code inspection.

Comment 10

[esther]

Thanks!