Closed Bug 78912 Opened 21 years ago Closed 21 years ago

nsMsgPrintEngine::SetStatusMessage() is leaking a string.

Categories

(MailNews Core :: Printing, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: jud, Assigned: jud)

Details

(Keywords: memory-leak)

Attachments

(2 files)

nsresult
nsMsgPrintEngine::SetStatusMessage(PRUnichar *aMsgString)
{
  PRUnichar     *progressMsg;

  if ( (!mFeedback) || (!aMsgString) )
    return NS_OK;

  progressMsg = nsCRT::strdup(aMsgString);
  mFeedback->ShowStatusString(progressMsg);
  return NS_OK;
}

progressMsg is being leaked.
Keywords: mlk
Target Milestone: --- → mozilla0.9.1
Keywords: patch
sr=mscottt....thanks jud.
r=rpotts.

I bet that you could get rid of the strdup() and free() all together in
nsMsgPrintEngine::SetStatusMessage(...)
some rhp extra str duping..

looks good.
sr=mscott
fix is in. thanks.
this was checked in yesterday.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
I need test scerario to verify this, please!
verified by code inspection.
Status: RESOLVED → VERIFIED
Thanks!
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.