789124 - Bug 777591 assumes the jar command to be used is in the search path

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Bill Gianopoulos [:WG9s]]

Bug 777591 assumes the jar comand to be used is in the search path.

It should respect the --with-java-bin-path configure option if it was specified.

Comment 1

[Bill Gianopoulos [:WG9s]]

I would have filed this as a blocker but managed to get my development builds to work by creating a symlink in my ~/bin directory to the correct jar command.

Comment 2

[Bill Gianopoulos [:WG9s]]

Turns out the symlink did not work.  I actually had to define an alias in my build process.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: JAR-not-jar.patch

Kyle, can you please review this Android makefile change?

I replaced `jar` with `$(JAR)` because I can't assume Java's jar tool is in PATH. The default value of $(JAR) works for me and I verified that I can override $(JAR) with mozconfig's --with-java-bin-path option.

Comment 4

[Chris Peterson [:cpeterson]]

Green try build:
https://tbpl.mozilla.org/?tree=Try&rev=7c293370745b

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/909bb2d2ef8a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/909bb2d2ef8a