Closed Bug 789309 Opened 8 years ago Closed 8 years ago

Un-export jsatom.h, jsatom.tbl

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Waldo, Assigned: Waldo)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Attached patch PatchSplinter Review
This seems to be standing in the way of some improvements to how we list atoms in JSAtomState's fields for easy use, at least if we don't want to export anything we don't already export.
Attachment #659023 - Flags: review?(jorendorff)
Comment on attachment 659023 [details] [diff] [review]
Patch

Review of attachment 659023 [details] [diff] [review]:
-----------------------------------------------------------------

Great.

::: js/src/jsfriendapi.h
@@ +1431,5 @@
> +NON_INTEGER_ATOM_TO_JSID(JSAtom *atom)
> +{
> +    JS_ASSERT(((size_t)atom & 0x7) == 0);
> +    jsid id = JSID_FROM_BITS((size_t)atom);
> +    JS_ASSERT(id == INTERNED_STRING_TO_JSID(NULL, (JSString*)atom));

This doesn't need a cast. Pre-existing code, I know, just noticed it in passing.
Attachment #659023 - Flags: review?(jorendorff) → review+
Actually it does -- the JSAtom-JSString inheritance relationship is in vm/String.h, which isn't an installed header.  :-)

http://hg.mozilla.org/integration/mozilla-inbound/rev/3916c4ac4a81
Target Milestone: --- → mozilla18
https://hg.mozilla.org/mozilla-central/rev/3916c4ac4a81
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [js:t]
You need to log in before you can comment on or make changes to this bug.