789309 - Un-export jsatom.h, jsatom.tbl

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

This seems to be standing in the way of some improvements to how we list atoms in JSAtomState's fields for easy use, at least if we don't want to export anything we don't already export.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 659023 [details] [diff] [review]
Patch

Review of attachment 659023 [details] [diff] [review]:
-----------------------------------------------------------------

Great.

::: js/src/jsfriendapi.h
@@ +1431,5 @@
> +NON_INTEGER_ATOM_TO_JSID(JSAtom *atom)
> +{
> +    JS_ASSERT(((size_t)atom & 0x7) == 0);
> +    jsid id = JSID_FROM_BITS((size_t)atom);
> +    JS_ASSERT(id == INTERNED_STRING_TO_JSID(NULL, (JSString*)atom));

This doesn't need a cast. Pre-existing code, I know, just noticed it in passing.

Comment 2

[Jeff Walden [:Waldo]]

Actually it does -- the JSAtom-JSString inheritance relationship is in vm/String.h, which isn't an installed header.  :-)

http://hg.mozilla.org/integration/mozilla-inbound/rev/3916c4ac4a81

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3916c4ac4a81