Closed
Bug 789311
Opened 13 years ago
Closed 13 years ago
Work - [Metro] Displaying the location bar should select the URL
Categories
(Firefox for Metro Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: platform-parity, polish, ux-efficiency, Whiteboard: feature=work [completed-elm] [parity-ie])
Attachments
(1 file, 2 obsolete files)
|
2.54 KB,
patch
|
fryn
:
review+
|
Details | Diff | Splinter Review |
When you edge-swipe to display the location bar, the text in the URL field should be selected by default.
(This is based on an assumption that entering a new URL is more common than editing the current one, and should require fewer taps. For comparsion, the default behavior is to select all when you click the location bar in desktop and mobile Firefox.)
Attachment #659027 -
Flags: review?(fryn)
|
Assignee | |
Comment 1•13 years ago
|
||
(Bug 776240 added code to do this on control-L; this patch moves that code so that it runs whenever the location bar appears.)
Depends on: 776240
|
|
Assignee | |
Comment 2•13 years ago
|
||
Fixed a bug in the previous patch and simplified it a bit.
Attachment #659027 -
Attachment is obsolete: true
Attachment #659027 -
Flags: review?(fryn)
Attachment #659266 -
Flags: review?(fryn)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Sorry for the churn; I'm still learning all the ways this code gets called. I'm also thinking we can make it easier to follow by continuing some of jwilde's refactoring work, but I want to get to know it a little better first.
Attachment #659266 -
Attachment is obsolete: true
Attachment #659266 -
Flags: review?(fryn)
Attachment #659397 -
Flags: review?(fryn)
|
||
Updated•13 years ago
|
Attachment #659397 -
Flags: review?(fryn) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [parity-ie] → [parity-ie][completed-elm]
|
|
||
Updated•13 years ago
|
Component: Location Bar → General
Product: Firefox → Firefox for Metro
Version: unspecified → Trunk
|
||
Updated•13 years ago
|
Summary: [Metro] Displaying the location bar should select the URL → Work - [Metro] Displaying the location bar should select the URL
Whiteboard: [parity-ie][completed-elm] → feature=work [completed-elm] [parity-ie]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Resolving bugs in the Firefox for Metro product that are fixed on the elm branch. Sorry for the bugspam. Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•