789313 - Long profile username breaks Messages folder layout

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect, P4)

Description

[Jonah Ho (AAstar)]

Overview: Messages folder layout is broken because a long profile username will shift the preceding messages out of place.

Build ID: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0

Steps to Reproduce: 
1. Receive a message from a user with a long username
2. Ask the same user to reply to their sent message

Actual Results:
The first message sent by the user appears below the second message, but is shifted out of place towards the right.

Expected Results:
The first message sent by the user should appear directly below the second message and not shifted at all.

Comment 1

[Jonah Ho (AAstar)]

For step #2 in Steps to Reproduce, it should be "Ask the same user to send another message."

Comment 2

[Kadir Topal [:atopal]]

Ricky, Rehan, let's keep this in mind when we redesign the private message window.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Attachment: Screenshot of message inbox in SUMO with long names

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Setting the mentored bit with other metadata.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Here is an example from https://support.mozilla.org/en-US/messages ,  with two messages from someone with a relatively long name. 

Looks like it isn't shifted to the right, but some information overlaps onto the horizontal divider line between the messages.

Comment 6

[Kadir Topal [:atopal]]

Yeah, there are also issues with messages that are too long. We restrict the box to a height of 48px, but the text won't always fit so it breaks into the next line. Since we are already truncating the text, we should just give it the space, or truncate more aggressively.

Comment 7

[Kadir Topal [:atopal]]

Attachment: cut off text

Comment 8

[Kadir Topal [:atopal]]

This was bugging me a lot, so I took at shot at it.

https://github.com/mozilla/kitsune/pull/1490

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/8f1da66003987d99aff18cce6be52702062bf9b7

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now. Thanks Kadir!