Closed Bug 789360 Opened 12 years ago Closed 12 years ago

references to modules using wrong url

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 18

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Whiteboard: completed-elm)

Attachments

(3 files, 1 obsolete file)

devtools-1
1.16 KB, patch
past
: review+
Details | Diff | Splinter Review
devtools-2
1.86 KB, patch
past
: review+
Details | Diff | Splinter Review
devtools-3
968 bytes, patch
past
: review+
Details | Diff | Splinter Review
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_bfcache.js | head.js import threw an exception - [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: chrome://mochitests/content/browser/browser/devtools/debugger/test/head.js :: <TOP_LEVEL> :: line 9" data: no]
Attached patch devtools (obsolete) — — Splinter Review
generalizing this bug for the rest.
Summary: browser/devtools/debugger/test/head.js references modules using wrong url → references to modules using wrong url
(In reply to Jim Mathies [:jimm] from comment #0) > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/ > head.js#9 > > These should all be gre paths I believe. Yes, that is true. How did you manage to get this error?
(In reply to Panos Astithas [:past] from comment #4) > (In reply to Jim Mathies [:jimm] from comment #0) > > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/ > > head.js#9 > > > > These should all be gre paths I believe. > > Yes, that is true. How did you manage to get this error? You have to be running "metro-build" related changes, which is currently on elm.
(In reply to Jim Mathies [:jimm] from comment #5) > (In reply to Panos Astithas [:past] from comment #4) > > (In reply to Jim Mathies [:jimm] from comment #0) > > > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/ > > > head.js#9 > > > > > > These should all be gre paths I believe. > > > > Yes, that is true. How did you manage to get this error? > > You have to be running "metro-build" related changes, which is currently on > elm. Ah, makes sense. If you want to change the other two imports in this file I can r+ it right away.
(In reply to Panos Astithas [:past] from comment #6) > (In reply to Jim Mathies [:jimm] from comment #5) > > (In reply to Panos Astithas [:past] from comment #4) > > > (In reply to Jim Mathies [:jimm] from comment #0) > > > > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/ > > > > head.js#9 > > > > > > > > These should all be gre paths I believe. > > > > > > Yes, that is true. How did you manage to get this error? > > > > You have to be running "metro-build" related changes, which is currently on > > elm. > > Ah, makes sense. If you want to change the other two imports in this file I > can r+ it right away. I haven't had a chance to run these tests locally so I wasn't sure. Is devtools a platform resource? Seemed like the service was the only path that needed updating. (I'll confirm this today when I get these tests running.)
(In reply to Jim Mathies [:jimm] from comment #7) > (In reply to Panos Astithas [:past] from comment #6) > > (In reply to Jim Mathies [:jimm] from comment #5) > > > (In reply to Panos Astithas [:past] from comment #4) > > > > (In reply to Jim Mathies [:jimm] from comment #0) > > > > > http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/test/ > > > > > head.js#9 > > > > > > > > > > These should all be gre paths I believe. > > > > > > > > Yes, that is true. How did you manage to get this error? > > > > > > You have to be running "metro-build" related changes, which is currently on > > > elm. > > > > Ah, makes sense. If you want to change the other two imports in this file I > > can r+ it right away. > > I haven't had a chance to run these tests locally so I wasn't sure. Is > devtools a platform resource? Seemed like the service was the only path that > needed updating. > > (I'll confirm this today when I get these tests running.) Yes, the debugger server and client are in toolkit/: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/debugger/debugger-controller.js#18 I had a successful test run locally with these 3 changes.
Attached patch devtools-1 — — Splinter Review
devtools/debugger changes
Assignee: nobody → jmathies
Attachment #659083 - Attachment is obsolete: true
Attachment #659234 - Flags: review?(past)
Attachment #659234 - Flags: review?(past) → review+
Status: NEW → ASSIGNED
Component: Developer Tools → Developer Tools: Debugger
Attached patch devtools-2 — — Splinter Review
Aside from one test affected by bug 789461 this gets devtools tests running successfully.
Attachment #659250 - Flags: review?(past)
oops, I'll remove that dump statement.
Comment on attachment 659250 [details] [diff] [review] devtools-2 Review of attachment 659250 [details] [diff] [review]: ----------------------------------------------------------------- Huh, I wonder how that snuck in there... r=me with the dump removed.
Attachment #659250 - Flags: review?(past) → review+
Attached patch devtools-3 — — Splinter Review
One more in styleinspector/test/browser_ruleview_734259_style_editor_link.js.
Attachment #659303 - Flags: review?
Attachment #659303 - Flags: review? → review?(past)
Attachment #659303 - Flags: review?(past) → review+
Whiteboard: completed-elm
https://hg.mozilla.org/mozilla-central/rev/a2db0bc00598
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: