789428 - [b2g-bluetooth] the object path of BluetoothDevice is null

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

This bug is caused by patch of bug 756299.

For each BluetoothDevice, its mPath should be a combination of adapter's object path and its address. We can't get its object path from DBus and should initialize its value when we get device address.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Damn. My fault having most of the end of development on 756299 be with devices that were already bonded. I'll fix it.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Fix object path setting for BluetoothDevice

I pushed path creation back into BluetoothDBusService, as part of any point where we'll pass back a set of properties for Devices. Not like address is ever going to change. Was having a problem finding a way to repro the issue, but I think this should fix it?

Comment 3

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 664230 [details] [diff] [review]
Patch 1 (v1) - Fix object path setting for BluetoothDevice

Review of attachment 664230 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

::: dom/bluetooth/BluetoothDevice.cpp
@@ +62,5 @@
>    for (uint32_t i = 0; i < values.Length(); ++i) {
>      SetPropertyByValue(values[i]);
> +    if (values[i].name().EqualsLiteral("Path")) {
> +      // Since this is our signal handler string, set it as we set the property
> +      // in the object. Odd place to do it, but since this

Not even a nit: Unfinished comment?

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=7b837b196ca1

https://hg.mozilla.org/integration/mozilla-inbound/rev/c544d6a5e993

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/c544d6a5e993