789439 - ForecastFox does not display in main window - does in a new window

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

ForecastFox is no longer being displayed in the main window add-on bar. 
Opening a new window does show the add-on.

STR:
Use a build prior to Sept 6 build
Install and configure ForecastFox
As I recall, ForecastFox from AMO will not run because it broke sometime ago when wrappers were removed, and there is hacked 'js' file to get around the wrapper issue.
Once its working update to Sept 6, or later and note its no longer displaying in the Add-on Bar.
No errors in Error Console. Configure page will not search city locations or update.

The 'wrapper fix' is here:
http://forums.mozillazine.org/viewtopic.php?f=23&t=2475539&hilit=+forecastfox

This appears in the Error Console2 when I open the new window:
Warning: XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block.
Source file: chrome://browser/content/browser.xul

Regression range:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d5589b88c8b&tochange=cfc884e6e414
Thanks Alice

Comment 1

[Alice0775 White]

Last good: 32ecf0cec2c3
First bad: b33228bc231a

Triggered by: b33228bc231a	Bobby Holley — Bug 774633 - Remove "is chrome window" condition for inner window reuse. r=jst

Comment 2

[Bobby Holley (:bholley)]

I doubt it has to do with the storage statement wrappers.

The jar that I found on mozillazine was minified, so it was hard to dig too much into. I did find this, though:

ww=Components.classes["@mozilla.org/embedcomp/window-watcher;1"].getService(Components.interfaces.nsIWindowWatcher);
win=ww.openWindow(null,chrome,"_blank",flags,args)

My (totally unsubstantiated) guess would be that ForecastFox subsequently tries to load unprivileged content into the type=chrome iframe, and gets surprised that we evict the inner window, blow away expandos, and drop chrome privielges.

Probably need the developer to take a look before much else happens.

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Well, thats not good news, the developer stated awhile back that he had no time for the addon, and was looking for someone to take over.  I have no idea if anyone stepped up.
If not, then this addon may just die, unless someone can look deeper.

Also, I see I have failed to note that if you open another window with Ctrl+N I do see tha addon and it appears to be working as normal, but does not appear in the main browser window if you only use one window.  (I'm not talking about two monitors, just open a new window)  

If the chrome privs are getting blown away, why is working in a new window.

Comment 4

[Bobby Holley (:bholley)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #3)
> Well, thats not good news, the developer stated awhile back that he had no
> time for the addon, and was looking for someone to take over.  I have no
> idea if anyone stepped up.
> If not, then this addon may just die, unless someone can look deeper.

Yeah, the addon is unlikely to survive very well without a maintainer or at least someone who knows how it works. Getting un-minified source for it is probably a decent first step.

> If the chrome privs are getting blown away, why is working in a new window.

The details of what's going on are sufficiently obscure at the moment that I don't think anyone has any idea.

Comment 5

[Gary King]

In regards to comment 4 does that mean that this bug will be a no fix?

Comment 6

[Bobby Holley (:bholley)]

(In reply to Gary King from comment #5)
> In regards to comment 4 does that mean that this bug will be a no fix?

It totally could be fixed. But it's currently not clear whether the bug is in Gecko or in ForecastFox. To figure that out, ForecastFox needs a maintainer, or at least a developer who's willing to look at this and put together a reduced testcase.

Comment 7

[Jon Stritar]

Forecastfox developer here. I'll take a look at this shortly and send you guys the uncompiled source.

Comment 8

[Bobby Holley (:bholley)]

(In reply to Jon Stritar from comment #7)
> Forecastfox developer here. I'll take a look at this shortly and send you
> guys the uncompiled source.

Awesome, thanks Jon!

This might be the same issue as bug 789773. I'm going to look into that one tomorrow.

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

It looks like this is an issue with the addon and not Firefox so we wouldn't track this for release.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Although, re: comment 6 - if this does turn out to be a Gecko issue please re-nominate for tracking with some background on how many addons/users would be affected by this.

Comment 11

[Jim Jeffery not reading bug-mail 1/2/11]

just tested the build from 'try-server' cset:
20120916151055 f9aac600cb86 for bug 789773 

The patch does not fix the problem with ForecastFox.

Comment 12

[Bobby Holley (:bholley)]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)
> just tested the build from 'try-server' cset:
> 20120916151055 f9aac600cb86 for bug 789773 
> 
> The patch does not fix the problem with ForecastFox.

Keep in mind that the patch there went orange, but still fixed the testcase in that bug. I'm looking into why it went orange.

Comment 13

[Jim Jeffery not reading bug-mail 1/2/11]

(In reply to Bobby Holley (:bholley) from comment #12)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #11)
> > just tested the build from 'try-server' cset:
> > 20120916151055 f9aac600cb86 for bug 789773 
> > 
> > The patch does not fix the problem with ForecastFox.
> 
> Keep in mind that the patch there went orange, but still fixed the testcase
> in that bug. I'm looking into why it went orange.

OK, thanks.. I falsely assumed the orange was due to the failing tests.

On another note, I just downloaded the latest m-i build win32 with your updated/fixed patch and sadly ForecastFox is still not working.  

Guess we now wait and see if anyone can figure out the addon.  Thanks for your help.

Comment 14

[Jim Jeffery not reading bug-mail 1/2/11]

Not yet on AMO, but author has updated the addon.  Other than the radar not updating as it should, the main part of the addon is now displaying again as it should. 

Get updated xpi here: 
https://groups.google.com/group/forecastfox-users/browse_thread/thread/fe1481bbdee037b