Report crashes with prerelease.dogfood.id if available

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: akeybl, Assigned: hub)

Tracking

(Blocks: 1 bug, {feature})

unspecified
feature
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: [LOE:S])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
If defined, we should use prerelease.dogfood.id as the email ID for crashes. It will be the asset tag number of the dogfooding phone, and will allow us to get in touch with users affected by a specific crash.

We may want to pull this code out prior to release, to prevent privacy concerns.
(Reporter)

Updated

6 years ago
Blocks: 761905
(Reporter)

Comment 1

6 years ago
Not sure how we want to handle this - it's basically pre-release only, but is a requirement for dogfooding, which is a requirement for shipping.

Nomming to see what triage thinks.
blocking-basecamp: --- → ?
(In reply to Alex Keybl [:akeybl] from comment #1)
> Not sure how we want to handle this - it's basically pre-release only, but
> is a requirement for dogfooding, which is a requirement for shipping.
> 
> Nomming to see what triage thinks.

Is a work-around for dogfooding possible for the email ID? That's probably the big factor for determining if it blocks or not.
While we wouldn't hold the release for this (the definition of a blocker we've been using in triage), it seems important enough so let's mark it at the very least so we don't forget to remove any code we add for dogfooding.
blocking-basecamp: ? → +
(Reporter)

Comment 4

6 years ago
(In reply to Jason Smith [:jsmith] from comment #2)
> Is a work-around for dogfooding possible for the email ID? That's probably
> the big factor for determining if it blocks or not.

I don't believe there's any alternative to ensuring 2-way conversations for crash reports.
(Reporter)

Comment 5

6 years ago
Thanks for helping out here Hub!
Assignee: nobody → hub
Keywords: feature
(Assignee)

Updated

6 years ago
Whiteboard: [LOE:S]
We're looking at getting devices in the coming week and I'm wondering how this is coming along, this is something we'll want to test out next week if possible to confirm that a phone's config pref that's set with a prerelease.dogfood.id is being handed back to us along with crash report data. 

Also - not sure if this is the place to ask but will there be a dialog after a crash asking for user input?
(In reply to Lukas Blakk [:lsblakk] from comment #6)
> 
> Also - not sure if this is the place to ask but will there be a dialog after
> a crash asking for user input?

See https://github.com/mozilla-b2g/gaia/issues/4149 for the proposal for the crash UI.
(Assignee)

Comment 8

6 years ago
It is blocked by 777145. Without the former, not crash report will ever be sent.
Depends on: 777145
(Assignee)

Comment 9

6 years ago
prerelease.dogfood.id is a preference value?

What annotation field shall I use for the crash reporter.
(Reporter)

Comment 10

6 years ago
(In reply to Hub Figuiere [:hub] from comment #9)
> prerelease.dogfood.id is a preference value?

We'll be using it as a preference value, although it is not a default pref. Do you foresee a problem there?

> What annotation field shall I use for the crash reporter.

Whichever field is typically used for email address can be instead used for this ID.
(Assignee)

Comment 11

6 years ago
Created attachment 665149 [details] [diff] [review]
Bug 789466 - Report crashes with prerelease.dogfood.id if available.
(Assignee)

Updated

6 years ago
Attachment #665149 - Flags: review?(jsmith)
Attachment #665149 - Flags: review?(21)
(Assignee)

Comment 12

6 years ago
The change in b2g/app/b2g.js will be skipped. I forgot to remove it when submitting the patch, but it illustrated the use to reviewers.
Status: NEW → ASSIGNED
Comment on attachment 665149 [details] [diff] [review]
Bug 789466 - Report crashes with prerelease.dogfood.id if available.

I probably can't conduct the review on this.
Attachment #665149 - Flags: review?(jsmith)
(Assignee)

Comment 14

6 years ago
(In reply to Jason Smith [:jsmith] from comment #13)
> Comment on attachment 665149 [details] [diff] [review]
> Bug 789466 - Report crashes with prerelease.dogfood.id if available.
> 
> I probably can't conduct the review on this.

Who can beside shell.js "owner" ?

Updated

6 years ago
Attachment #665149 - Flags: review?(21) → review+
Comment on attachment 665149 [details] [diff] [review]
Bug 789466 - Report crashes with prerelease.dogfood.id if available.

Review of attachment 665149 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +109,5 @@
>     },
>  
>    start: function shell_start() {
> +
> +    let dogfoodId = Services.prefs.getCharPref('prerelease.dogfood.id');

doesn't this throw if the pref is not set at all?

@@ +112,5 @@
> +
> +    let dogfoodId = Services.prefs.getCharPref('prerelease.dogfood.id');
> +    if (dogfoodId != "") {
> +      let cr = Cc["@mozilla.org/xre/app-info;1"]
> +        .getService(Ci.nsICrashReporter);

nit: align .getService with the [ on the previous line
Attachment #665149 - Flags: review+ → review?(21)
(Assignee)

Comment 16

6 years ago
Created attachment 665157 [details] [diff] [review]
Bug 789466 - Report crashes with prerelease.dogfood.id if available.

Addressed Fabrice comment. Remove the prefs change as well.
Attachment #665149 - Attachment is obsolete: true
Attachment #665149 - Flags: review?(21)
Attachment #665157 - Flags: review?(21)
Attachment #665157 - Flags: review?(21) → review+
https://hg.mozilla.org/mozilla-central/rev/5caee20d2dc6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 777187
You need to log in before you can comment on or make changes to this bug.