789469 - WindowsJumpLists should use ExecutableD for handler app paths

Status: RESOLVED FIXED

(Firefox :: General, defect)

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 659260 [details] [diff] [review]
patch

This isn't correct. In the case of Firefox-on-XR, GreD wouldn't contain firefox.exe. I think you need to create a new key for this case where we're sharing a firefox.exe between win32 and metro.

Comment 3

[Brian R. Bondy [:bbondy]]

yoink

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Ditto this is for m-c.

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/projects/elm/rev/441b9cc876cd

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 665009 [details] [diff] [review]
Patch v1

ditto here.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Get the executable path directly from the directory service instead of guesswork in WindowsJumpLists.jsm

Comment 8

[Brian R. Bondy [:bbondy]]

The first patch in this bug is still pending to land on m-c by the way until the current exe dir's dir service bug gets reviewed by bsmedberg.

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d79efc8541

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8d79efc8541