789592 - rename nsChangeHint_ReflowFrame and use it less

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I always have trouble remembering which of the reflow-related nsChangeHint_* values is the one that's the bitmask containing all the others.  (Answer: nsChangeHint_ReflowFrame.)

I'd like to rename this to nsChangeHint_AllReflowHints so it's clearer which one it is.

I also think we can use it a bit less; there are a few places using it that are probably dating back to when it was a single bit, and should really be looking at one of the single bits.

Patches coming shortly.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Change some uses of nsChangeHint_ReflowFrame to check nsChangeHint_NeedReflow. (, patch 1)

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Rename nsChangeHint_ReflowFrame to nsChangeHint_AllReflowHints to make it clearer that it's the one that contains multiple bits. (, patch 2)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 659356 [details] [diff] [review]
Change some uses of nsChangeHint_ReflowFrame to check nsChangeHint_NeedReflow.  (, patch 1)

r=me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 659357 [details] [diff] [review]
Rename nsChangeHint_ReflowFrame to nsChangeHint_AllReflowHints to make it clearer that it's the one that contains multiple bits.  (, patch 2)

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d8b251f64d
https://hg.mozilla.org/integration/mozilla-inbound/rev/93f98bebfe39

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b4d8b251f64d
https://hg.mozilla.org/mozilla-central/rev/93f98bebfe39