789597 - Should support correlation of profile with capture frames

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect)

Description

[William Lachance (:wlach)]

This has two components:

1. Doing the correlation inside BenWa's profiler between the webm video of the capture and the profile.
2. Turning on the setting to do frame numbering in fennec (layers.acceleration.frame-counter) when capturing with profiling enabled.

Not sure about the status of (1). I have a patch to do (2), but unfortunately the web page just seems to render as a grey box in eideticker with it enabled. Needs investigation.

Comment 1

[William Lachance (:wlach)]

Attachment: Turn on frame numbering when profiling enabled

Attaching patch to do what we want here (I don't think it should really require review; attaching it just for reference)

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 3

[Benoit Girard (:BenWa)]

review ping

Comment 4

[William Lachance (:wlach)]

(In reply to Benoit Girard (:BenWa) from comment #2)
> Created attachment 659559 [details] [diff] [review]
> patch

No idea why, but this fixes the issue I reported above. :)

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 659559 [details] [diff] [review]
patch

Maybe you can get to this first joe. The sooner this lands the sooner we can get some results back from eideticker to implement the frame syncing.

Comment 6

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/318635207dcb

Comment 7

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/318635207dcb

Comment 8

[Benoit Girard (:BenWa)]

Looks good to me, once we get our first result on eideticker I'll deploy the changes to cleopatra.

Comment 9

[William Lachance (:wlach)]

Pushed the eideticker-side changes:

https://github.com/mozilla/eideticker/commit/a317331be929234ac58e3346dfada412785239a0