Closed Bug 789597 Opened 8 years ago Closed 8 years ago

Should support correlation of profile with capture frames

Categories

(Testing Graveyard :: Eideticker, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: wlach, Assigned: BenWa)

References

Details

Attachments

(2 files)

This has two components:

1. Doing the correlation inside BenWa's profiler between the webm video of the capture and the profile.
2. Turning on the setting to do frame numbering in fennec (layers.acceleration.frame-counter) when capturing with profiling enabled.

Not sure about the status of (1). I have a patch to do (2), but unfortunately the web page just seems to render as a grey box in eideticker with it enabled. Needs investigation.
Attaching patch to do what we want here (I don't think it should really require review; attaching it just for reference)
Attached patch patchSplinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #659559 - Flags: review?(jmuizelaar)
review ping
(In reply to Benoit Girard (:BenWa) from comment #2)
> Created attachment 659559 [details] [diff] [review]
> patch

No idea why, but this fixes the issue I reported above. :)
Comment on attachment 659559 [details] [diff] [review]
patch

Maybe you can get to this first joe. The sooner this lands the sooner we can get some results back from eideticker to implement the frame syncing.
Attachment #659559 - Flags: review?(joe)
Attachment #659559 - Flags: review?(joe)
Attachment #659559 - Flags: review?(jmuizelaar)
Attachment #659559 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/318635207dcb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Looks good to me, once we get our first result on eideticker I'll deploy the changes to cleopatra.
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.