click-to-play: a plugin made click-to-play by the blocklist won't go back to normal if unblocked

RESOLVED FIXED in Firefox 17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

Trunk
mozilla18
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox17 fixed, firefox18 fixed)

Details

Attachments

(1 attachment)

So, it turns out if we were to blocklist a plugin but later undo that block, the plugin would stay click-to-play.
Created attachment 659409 [details] [diff] [review]
patch
Attachment #659409 - Flags: review?(bmcbride)
(Assignee)

Updated

5 years ago
Blocks: 738698
Comment on attachment 659409 [details] [diff] [review]
patch

Review of attachment 659409 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/nsBlocklistService.js
@@ +970,5 @@
>          plugin.blocklisted = state == Ci.nsIBlocklistService.STATE_BLOCKED;
>          if (state == Ci.nsIBlocklistService.STATE_VULNERABLE_UPDATE_AVAILABLE ||
>              state == Ci.nsIBlocklistService.STATE_VULNERABLE_NO_UPDATE)
>            plugin.clicktoplay = true;
> +        // turn off clicktoplay if it was previously set by the blocklist

Hmm, just realized this is going to be a pain when we expose UI for click-to-play for individual plugins (bug 549697), since this will undo the user's choice. Before we get that UI, I think we'll have to separate out blocklist-setting and user-setting for clicktoplay. Shouldn't be too painful - change usage here to .blocklistClicktoplay, add a .userClicktoplay, and make .clicktoplay only an accessor property whose value is based on those two.
Attachment #659409 - Flags: review?(bmcbride) → review+
This ran green: https://tbpl.mozilla.org/?tree=Try&rev=49bef3992cf8
Marking checkin-needed.
Keywords: checkin-needed
Comment on attachment 659409 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/74d24d902ad6
Attachment #659409 - Flags: checkin+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/74d24d902ad6
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Comment on attachment 659409 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): blocklist/click-to-play plugins (bug 760625)
User impact if declined: if a plugin is click-to-play-blocklisted and then removed from the blocklist, it will continue to be a click-to-play plugin (with no UI to make it go back to normal)
Testing completed (on m-c, etc.): tested on m-c, been on nightly for a few weeks
Risk to taking this patch (and alternatives if risky): no particular risk
String or UUID changes made by this patch: none
Attachment #659409 - Flags: approval-mozilla-aurora?

Comment 7

5 years ago
Comment on attachment 659409 [details] [diff] [review]
patch

[Triage Comment]
Good fix for a newly uplifted feature.
Attachment #659409 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Whiteboard: [patch needs uplift to Aurora]
https://hg.mozilla.org/releases/mozilla-aurora/rev/21dc87c86767
status-firefox17: --- → fixed
status-firefox18: --- → fixed
Keywords: checkin-needed
Whiteboard: [patch needs uplift to Aurora]
You need to log in before you can comment on or make changes to this bug.