789623 - make package-tests is packaging .pyc files for mozbase components

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

When running make package-tests, .pyc files for mozbase components are being packaged.  In one particular instance, when attempting to commit bug 788842, this resulted in a build failure on OSX 10.7:

if test -d obj-firefox/i386/dist/test-package-stage -a                 \
                -d obj-firefox/x86_64/dist/test-package-stage; then              \
           cp obj-firefox/i386/dist/test-package-stage/mochitest/automation.py \
             obj-firefox/x86_64/dist/test-package-stage/mochitest/;              \
           cp obj-firefox/i386/dist/test-package-stage/reftest/automation.py   \
             obj-firefox/x86_64/dist/test-package-stage/reftest/;                \
           /builds/slave/m-in-osx64/build/build/macosx/universal/unify                 \
             --unify-with-sort "\.manifest$" \
             --unify-with-sort "all-test-dirs\.list$"               \
             obj-firefox/i386/dist/test-package-stage                          \
             obj-firefox/x86_64/dist/test-package-stage                          \
             obj-firefox/i386/dist/universal/test-package-stage; fi
/builds/slave/m-in-osx64/build/build/macosx/universal/unify: copyIfIdentical: files differ:
  obj-firefox/i386/dist/test-package-stage/mozbase/manifestdestiny/manifestparser/manifestparser.pyc,
  obj-firefox/x86_64/dist/test-package-stage/mozbase/manifestdestiny/manifestparser/manifestparser.pyc
make[2]: *** [postflight_all] Error 1
make[1]: *** [realbuild] Error 2
make: *** [build] Error 2

full log here: https://tbpl.mozilla.org/php/getParsedLog.php?id=15059998&tree=Mozilla-Inbound&full=1

I don't think we should be packaging .pyc files.

Comment 1

[Phil Ringnalda (:philor)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=15069244&tree=Profiling

Comment 2

[(not currently active) Ted Mielczarek]

I patched this in alder because I hit it there after updating mozbase:
http://hg.mozilla.org/projects/alder/rev/51cd733b5425

Comment 3

[Jeff Hammel]

It sounds like we should be doing this on m-c too.  :ted, does alder merge to m-c?  What is the way of getting this changeset there?

Comment 4

[(not currently active) Ted Mielczarek]

Alder is complicated, but we can just cherry-pick that commit back to m-c. I'll attach it for review in a minute.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: Skip packaging pyc tests in test package

Comment 6

[Phil Ringnalda (:philor)]

Landed in https://hg.mozilla.org/integration/mozilla-inbound/rev/8c710e778c97 since https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba9fa0f8194 made it a little less intermittent and more the-last-three-builds-in-a-row.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8c710e778c97