789633 - GC: Improve naming of AssertRootingUnnecessary

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

Steve and I settled on AutoAssertNoGC.  This also includes several fixes to the way we make the assertion to make it easier to mix in to other classes that want to implicitly have this assertion.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 659418 [details] [diff] [review]
v0

Review of attachment 659418 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Root.h
@@ +16,5 @@
>  #include "js/TemplateLib.h"
> +
> +#if defined(JSGC_ROOT_ANALYSIS) || defined(JSGC_USE_EXACT_ROOTING)
> +# include "jspubtd.h"
> +#endif

I would prefer if this include were unconditional. It's just one more place to update if we change around our #ifdef tangle, and given that jsapi.h already includes it, it's no big deal to include it unnecessarily.

@@ +476,5 @@
>  extern void
>  CheckStackRoots(JSContext *cx);
>  #endif
>  
> +JS_FRIEND_API(bool) IsRelaxRootChecksSet();

This name is a little funky (I first read it as "is this a set of 'relax root checks', whatever those might be?"). But I don't have a better suggestion, probably partly because I don't know what this is used for.

Comment 2

[Terrence Cole [:terrence]]

Removed conditional guards and updated the name to NeedRelaxedRootChecks.

Pushed at:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ac83718e89b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ac83718e89b