Closed
Bug 789643
Opened 12 years ago
Closed 12 years ago
Fix `GetCOMPtrCount() defined but not used` warning in nsTraceRefcntImpl.cpp
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
GetCOMPtrCount() is called from NS_LogCOMPtrAddRef() and NS_LogCOMPtrRelease(), but only #if defined(NS_IMPL_REFCNT_LOGGING) && defined(HAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR). My patch wraps the GetCOMPtrCount() function definition in #if defined(NS_IMPL_REFCNT_LOGGING) && defined(HAVE_CPP_DYNAMIC_CAST_TO_VOID_PTR), too.
Attachment #659426 -
Flags: review?(benjamin)
|
Assignee | |
Comment 1•12 years ago
|
||
Green try build: https://tbpl.mozilla.org/?tree=Try&rev=76f217cdc1aa
|
||
Updated•12 years ago
|
Attachment #659426 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/423607b0117d
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/423607b0117d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•