789717 - Use JS_InternStringN to avoid large memory usage in the profiler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Use JS_InternStringN to avoid large memory usage in the profiler

We duplicate a large number of strings. This helps cut down on that.

Comment 1

[Benoit Girard (:BenWa)]

I can't find any documentation on JS_InternStringN. How does it work?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

(In reply to Benoit Girard (:BenWa) from comment #1)
> I can't find any documentation on JS_InternStringN. How does it work?

A hash table of atoms is maintained, if the hash matches it returns a reference to that atom instead of a copy of the string. I wasn't able to figure out how expiry works.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7096242b4edd

Comment 4

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/7096242b4edd