The default bug view has changed. See this FAQ.

Add an OSX variable to the reftest condition sandbox to make it easier to test Mac OS X versions

RESOLVED FIXED in Firefox 16

Status

Testing
Reftest
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: philor, Assigned: dbaron)

Tracking

(Blocks: 5 bugs)

Trunk
mozilla18
x86_64
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox16 fixed, firefox17 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 659551 [details] [diff] [review]
fix v.1

We've been using the pile-of-toothpicks condition "(/Mac\x20OS\x20X\x2010\.5/.test(http.oscpu))" for Mac versions in reftest conditions, but I couldn't face copy-pasting it yet again for seven more 10.8 ifs.

Inconveniently, this is dbaron's patch from https://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/19b83bbbcbd6/condition-sandbox-osx minus the anchor at the start of the regex (oscpu is "Intel Mac OS X 10.8" rather than "Mac OS X 10.8"), so I can't really expect him to review it.

https://tbpl.mozilla.org/?tree=Try&rev=27f3ef4ee4df&noignore=1 is it working fine (the 10.8 orange is because I've only patched the first couple of failures).
Attachment #659551 - Flags: review?(roc)
Attachment #659551 - Flags: review?(roc) → review+
(Reporter)

Comment 1

5 years ago
The variable in https://hg.mozilla.org/integration/mozilla-inbound/rev/ebff207c2574, using it for the existing conditions and dumping the unsupported 10.5 in https://hg.mozilla.org/integration/mozilla-inbound/rev/349231ac63a1
Assignee: nobody → dbaron
(Assignee)

Comment 2

5 years ago
Thanks for fixing and landing it for me.
https://hg.mozilla.org/mozilla-central/rev/ebff207c2574
https://hg.mozilla.org/mozilla-central/rev/349231ac63a1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/daf8136d8589
https://hg.mozilla.org/releases/mozilla-beta/rev/48737e8e81e3
status-firefox16: --- → fixed
status-firefox17: --- → fixed
Whiteboard: [qa-]
(Assignee)

Updated

2 years ago
Depends on: 1121327
You need to log in before you can comment on or make changes to this bug.