789771 - Add an OSX variable to the reftest condition sandbox to make it easier to test Mac OS X versions

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: fix v.1

We've been using the pile-of-toothpicks condition "(/Mac\x20OS\x20X\x2010\.5/.test(http.oscpu))" for Mac versions in reftest conditions, but I couldn't face copy-pasting it yet again for seven more 10.8 ifs.

Inconveniently, this is dbaron's patch from https://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/19b83bbbcbd6/condition-sandbox-osx minus the anchor at the start of the regex (oscpu is "Intel Mac OS X 10.8" rather than "Mac OS X 10.8"), so I can't really expect him to review it.

https://tbpl.mozilla.org/?tree=Try&rev=27f3ef4ee4df&noignore=1 is it working fine (the 10.8 orange is because I've only patched the first couple of failures).

Comment 1

[Phil Ringnalda (:philor)]

The variable in https://hg.mozilla.org/integration/mozilla-inbound/rev/ebff207c2574, using it for the existing conditions and dumping the unsupported 10.5 in https://hg.mozilla.org/integration/mozilla-inbound/rev/349231ac63a1

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Thanks for fixing and landing it for me.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ebff207c2574
https://hg.mozilla.org/mozilla-central/rev/349231ac63a1

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/daf8136d8589
https://hg.mozilla.org/releases/mozilla-beta/rev/48737e8e81e3