Closed Bug 789781 Opened 8 years ago Closed 8 years ago
Switch to new drag and drop api in tabbrowser
We're still using the old drag and drop API in tabbrowser, so this patch fixes that
Attachment #659564 - Flags: review?(neil)
Attachment #659564 - Flags: review?(neil) → review-
Fixed review comments where possible. I had spotted the missing drop indicator when I first wrote the patch and had worked out why but forgot about it when submitting. Anyway should be fixed now. As for removal, bug 719188 mentions flagging nsDragAndDrop.js and nsTransferable.js as deprecated but no confirmation of if and when.
Comment on attachment 659603 [details] [diff] [review] Revised switch Not tested yet. >+ dt.mozSetDataAt("application/x-moz-node", target, 0); [???] >+ var dt = aEvent.dataTransfer; >+ var draggedTab = dt.mozSourceNode; Nit: move these to where you use them. >+ var within = draggedTab && >+ draggedTab.parentNode == this.tabContainer; ... >+ var within = draggedTab && >+ draggedTab.parentNode == this.tabContainer; Oops.
Fixed duplication and missing removal. var dt lines moved closer to use.
Comment on attachment 660006 [details] [diff] [review] Switch with less within [Checked in: Comment 5] http://hg.mozilla.org/comm-central/rev/ab06a84a717a
Attachment #660006 - Attachment description: Switch with less within → Switch with less within [Checked in: Comment 5]
You need to log in before you can comment on or make changes to this bug.