789785 - [inspector] Change wording of "Only user styles" checkbox

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Paul Rouget [:paul]]

The User Styles checkbox is confusing for at least 2 reasons:
- the web developer doesn't see him as the "user" but as the "author". So the wording is wrong.
- as soon as you're searching, you don't get the default computed styles

My recommendation is to remove the checkbox and to show everything. But to show the "Author Style" first, then show a separator, and then list the "Default Style".

Comment 1

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] from comment #0)
> The User Styles checkbox is confusing for at least 2 reasons:
> - the web developer doesn't see him as the "user" but as the "author". So
> the wording is wrong.
> - as soon as you're searching, you don't get the default computed styles
> 
> My recommendation is to remove the checkbox and to show everything. But to
> show the "Author Style" first, then show a separator, and then list the
> "Default Style".

If we wanted to keep the checkbox (and things do look quite cluttered with it off), we could label it "Show Browser Styles".

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

The points raised in bug 740055 should be considered here as well. Also, are the performance issues mentioned in bug 672746 with displaying everything solved by now? Will showing everything cause a noticeable lag when populating the inspector?

I'm not concerned about doing a 180 degree turn on this, as long as we have the data to back it up, and we are sure that we won't have to do another u-turn in the future.

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

"Show Browser Styles" is confusing ... the correct term is "Show Author Styles."

Comment 4

[Paul Rouget [:paul]]

If we only go for a renaming, what about doing it the other way around? "Show browser style" (or UA). I think it's easier to understand.

Comment 5

[Joe Walker [:jwalker]]

(In reply to Paul Rouget [:paul] from comment #4)
> If we only go for a renaming, what about doing it the other way around?
> "Show browser style" (or UA). I think it's easier to understand.

Paul got to this suggestion before me, but I wholeheartedly agree.

Comment 6

[Paul Rouget [:paul]]

(In reply to Joe Walker [:jwalker] from comment #5)
> (In reply to Paul Rouget [:paul] from comment #4)
> > If we only go for a renaming, what about doing it the other way around?
> > "Show browser style" (or UA). I think it's easier to understand.
> 
> Paul got to this suggestion before me, but I wholeheartedly agree.

Oh, just saw comment 1 :)

Comment 8

[Paul Rouget [:paul]]

Bug triage, filter on PINKISBEAUTIFUL

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

This simple patch reverses the logic of the computed view's "Only user styles" checkbox and changes the label to "Browser styles."

All tests pass etc.

Comment 10

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/46b0f4fe4ef2

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/46b0f4fe4ef2