789787 - Thunderbird build with Windows SDK 8.0 fails because MAPI headers are missing

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Rain [:rain1] (inactive)]

A Thunderbird build using the Windows SDK 8.0 fails because the MAPI headers aren't found.

https://connect.microsoft.com/VisualStudio/feedback/details/728601/visual-c-mapiutil-h-and-xcmc-h-are-missing-from-platform-sdk-included-with-vc11-beta

Comment 1

[Rain [:rain1] (inactive)]

Installing the MAPI headers separately seems to be the only option. I've hacked the install path into INCLUDE locally. http://www.microsoft.com/download/en/details.aspx?displaylang=en&id=12905

I couldn't find the path anywhere in the registry, so the reg trick we use to locate the DirectX SDK won't work. This sucks. We'll probably have to hardcode the default path and provide a configure option to set it.

Comment 2

[Makoto Kato [:m_kato]]

We should check mapix.h in configure.in

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Part 1. Build config change (detect MAPI header and add --disable-mapi)

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Part 2. can build mailnews if no mapi header

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 721060 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)

Windows 8 SDK has no MAPI headers.  Even if no MAPI header, we should support it with --disable-mapi.

Also we can download MAPI header from microsoft.com.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 721062 [details] [diff] [review]
Part 2. can build mailnews if no mapi header

If no MAPI header in build environment, we should support it even if MSVC.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 721060 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)

Hi Makato, could you refresh this now that bug 846540 has landed - you need to move the changes to mail/configure.in and suite/configure.in.

I'll be happy to review both patches - I can review them as one.

Comment 8

[Makoto Kato [:m_kato]]

Attachment: Part 1. Build config change (detect MAPI header and add --disable-mapi)

Comment 9

[Makoto Kato [:m_kato]]

Attachment: Part 2. can build mailnews if no mapi header

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 737783 [details] [diff] [review]
Part 1. Build config change (detect MAPI header and add --disable-mapi)

I need update again.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: Part 1. build config change

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 737785 [details] [diff] [review]
Part 2. can build mailnews if no mapi header

Sorry, I forget update suite/*

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 738367 [details] [diff] [review]
Part 1. build config change

sorry, I forget udapte suite/*

Comment 14

[Makoto Kato [:m_kato]]

Attachment: Part 1. build config change

add --disable-mapi flag

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 738368 [details] [diff] [review]
Part 1. build config change

As this is just manually disabling, I think that's fine.

Comment 16

[Mark Banner (:standard8)]

Attachment: Part 1. build config change v2

and here's the unbitrotted patch for you.

Comment 17

[Mark Banner (:standard8)]

Attachment: Part 2. can build mailnews if no mapi header v2

I'm fine with this patch as well (attaching unbitrotted version).

Comment 18

[Mark Banner (:standard8)]

I've just landed this as it'll help people struggling with the mapi headers.

https://hg.mozilla.org/comm-central/rev/a5ad797c274a
https://hg.mozilla.org/comm-central/rev/bfe4e360ee05

Comment 19

[Philip Chee]

Doesn't Suite need this bit as well?
https://hg.mozilla.org/comm-central/rev/bfe4e360ee05#l1.12

Comment 20

[Makoto Kato [:m_kato]]

(In reply to Philip Chee from comment #19)
> Doesn't Suite need this bit as well?
> https://hg.mozilla.org/comm-central/rev/bfe4e360ee05#l1.12

https://hg.mozilla.org/comm-central/rev/a5ad797c274a has buildconfig change for suite too.

Comment 21

[Mike Kaply [:mkaply]]

Where do the headers need to go? I'm assuming they aren't being looked for in

C:\Office 2010 Developer Resources\Outlook 2010 MAPI Headers

Comment 22

[Mike Kaply [:mkaply]]

Never mind. If anyone else ends up here:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites