789827 - Fix nullptr abuse in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch v1

comm-central uses nullptr in areas where it shouldn't be used. This fixes those cases.

Comment 1

[Masatoshi Kimura [:emk]]

>-          tmp = '%'; *end = nullptr;
>+          tmp = '%'; *end = NULL;
>         }
>         else if (end-1 > start && *(end-1) == '%')
>         {
>-          end -= 1; tmp = '%'; *end = nullptr;
>+          end -= 1; tmp = '%'; *end = NULL;
>         }
>         else if (end-2 > start && *(end-2) == '%')
>         {
>-          end -= 2; tmp = '%'; *end = nullptr;
>+          end -= 2; tmp = '%'; *end = NULL;
>         }
>         else
>         {
>-          tmp = *end; *end = nullptr;
>+          tmp = *end; *end = NULL;
|*end = 0;| or |*end = '\0';|. *end is not a pointer.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 659594 [details] [diff] [review]
patch v1

r=me with the change of END -> 0 for the "*end = " cases. I'll land this in a moment as the tree is busted with this.

Comment 3

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/d210f0b60e38