789838 - Firefox win32 l10n nightlies busted with missing branding.nsi in make installers-ab-CD

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

eg http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1347201876.1347202149.5944.gz&fulltext=1

mkdir l10ngen
e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/_virtualenv/Scripts/python.exe /e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py -t ../../../browser/installer/windows/app.tag ../../../browser/installer/windows/nsis/installer.nsi ../../../browser/installer/windows/nsis/uninstaller.nsi ../../../browser/installer/windows/nsis/shared.nsh ../../../browser/installer/windows/nsis/maintenanceservice_installer.nsi l10ngen
e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/_virtualenv/Scripts/python.exe /e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py -t ../../../dist/branding/branding.nsi ../../../dist/branding/wizHeader.bmp ../../../dist/branding/wizHeaderRTL.bmp ../../../dist/branding/wizWatermark.bmp l10ngen
Traceback (most recent call last):
  File "e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py", line 181, in <module>
    sys.exit(_nsinstall_internal(argv[1:]))
  File "e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py", line 146, in _nsinstall_internal
    copy_all_entries(args, target)
  File "e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py", line 107, in copy_all_entries
    handleTarget(e, dest)
  File "e:/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows/../../../config/nsinstall.py", line 134, in handleTarget
    shutil.copy2(srcpath, targetpath)
  File "d:\mozilla-build\python25\lib\shutil.py", line 91, in copy2
    copyfile(src, dst)
  File "d:\mozilla-build\python25\lib\shutil.py", line 46, in copyfile
    fsrc = open(src, 'rb')
IOError: [Errno 2] No such file or directory: u'e:\\builds\\moz2_slave\\m-cen-w32-l10n-ntly\\build\\mozilla-central\\dist\\branding\\branding.nsi'
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/installer/windows'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w32-l10n-ntly/build/mozilla-central/browser/locales'
make[2]: *** [l10ngen/setup.exe] Error 1
make[1]: *** [repackage-win32-installer] Error 2
make: *** [repackage-win32-installer-kn] Error 2
program finished with exit code 2

Broken in the nightlies of the 8th, working prior to that. Possibly fallout from bug 786520, which was revealed by the clobber between 7th and 8th.

Comment 1

[Gregory Szorc [:gps]]

I suppose we should back out https://hg.mozilla.org/mozilla-central/rev/8d9c80e2f95b then I'll look into this as I try to re-land bug 786520.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

I took a look at one of the build slaves, the only branding.nsi files are in srcdir/browser/branding/*/, and dist/branding is empty. These builds don't use an objdir.

Leaving it to Axel to comment on how soon these builds should be fixed up.

Comment 3

[Axel Hecht [:Pike]]

We should back this out, and only reland it once it's working for l10n builds.

Comment 4

[Gregory Szorc [:gps]]

I backed out bug 786520. This should work in the next round of nightly builds.