Closed Bug 789849 Opened 8 years ago Closed 8 years ago

Use PNG instead of TIFF for cursor/pointer resources

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Dolske, Assigned: Dolske)

References

Details

Attachments

(1 file)

Attached patch Patch v.0Splinter Review
We currently ship a number of TIFF files for mouse pointers (cursors) types which are not supported by the base OS. OS X supports PNG for these, and it would be far more convenient to just use PNG instead of the terrible TIFF format.

This patch is a mostly-mechanical result of me using Preview.app to export all the current TIFF images as PNG. I then ran them though pngcrush just for good measure.

(Working though a weird compile-time issue ATM, but I think this patch works)
Attachment #659615 - Attachment is patch: true
Webkit switched quite some time ago: https://bugs.webkit.org/show_bug.cgi?id=11291
Comment on attachment 659615 [details] [diff] [review]
Patch v.0

Seems to work fine with the testcase in bug 784909. (Though till fuzzy in HiDPI mode, as expected)
Attachment #659615 - Attachment description: Patch v.0 (WIP) → Patch v.0
Attachment #659615 - Flags: review?(smichaud)
https://tbpl.mozilla.org/?tree=Try&rev=d09812c73407

Couple of weird errors on debug xpcshell (something about file permissions in some cache dir), but I _think_ it's not me.
(Bug 752243 I am now told)
Comment on attachment 659615 [details] [diff] [review]
Patch v.0

Moving review, since Steven noted he's swamped with HiDPI plugin stuff.
Attachment #659615 - Flags: review?(smichaud) → review?(joshmoz)
Attachment #659615 - Flags: review?(joshmoz) → review+
https://hg.mozilla.org/mozilla-central/rev/767157026993
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Assignee: nobody → dolske
You need to log in before you can comment on or make changes to this bug.