Closed Bug 789852 Opened 7 years ago Closed 7 years ago

Cannot specify text editor to source_view.editor.path if it's located in non-ASCII folder

Categories

(Toolkit :: View Source, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: intl)

Attachments

(1 file)

Current code use nsIPrefBranch.getCharPref() and nsIFile.initWithPath(). Internal type of the getCharPref() is const char*. On the other hand, the type of the param of initWithPath() is nsAString&. So, the code causes lossy conversion.
Attached patch PatchSplinter Review
Attachment #659619 - Flags: review?(gavin.sharp)
Attachment #659619 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/d042ad078f43
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.