789852 - Cannot specify text editor to source_view.editor.path if it's located in non-ASCII folder

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Current code use nsIPrefBranch.getCharPref() and nsIFile.initWithPath(). Internal type of the getCharPref() is const char*. On the other hand, the type of the param of initWithPath() is nsAString&. So, the code causes lossy conversion.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

Attachment: Patch

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d042ad078f43

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d042ad078f43