789873 - RequestWhiner doesn't respect SecureMail settings for "Outstanding Requests" mail

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Reed Loden [:reed]]

The RequestWhiner extension doesn't respect SecureMail settings for the "Outstanding Requests" weekly mail that gets sent out.

Comment 1

[:glob ✱]

we need to add an x-bugzilla-type header, and add code to securemail similar to whine processing.

Comment 2

[David Lawrence [:dkl]]

taking

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to encrypt requestwhine emails if contains secure bugs (v1)

This makes the request whines work similarly to standard whines.

1. The request whine header contains X-Bugzilla-Type: whine
2. SecureMail sees the header and then parses the text/plain part of the email for bug ids. 
3. If one or more bug ids are secure bugs, it will encrypt the entire message with the user's key/cert or replace the body with a message stating it was secure.
4. I also updated the code in whineatrequests.pl to use proper building of multipart messages using Email::MIME similar to bug 714724.

dkl

Comment 4

[:glob ✱]

Comment on attachment 659854 [details] [diff] [review]
Patch to encrypt requestwhine emails if contains secure bugs (v1)

r=glob

Comment 5

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified extensions/RequestWhiner/bin/whineatrequests.pl
Committed revision 8324.
Committing to: bzr+ssh://[e-mail]/bmo/4.0
added extensions/RequestWhiner/template/en/default/requestwhiner/header.txt.tmpl
Committed revision 8325.

Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified extensions/RequestWhiner/bin/whineatrequests.pl
added extensions/RequestWhiner/template/en/default/requestwhiner/header.txt.tmpl
Committed revision 8346.