Closed Bug 789954 Opened 7 years ago Closed 7 years ago

TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | Test timed out. (Port Port Bug 778420 - Fix up tests that don't like the new enablePrivilege)

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.15

People

(Reporter: philip.chee, Assigned: philip.chee)

Details

Attachments

(3 files)

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1347015362.1347016614.2700.gz#err0

1805 ERROR TEST-UNEXPECTED-FAIL | /tests/suite/browser/test/test_contextmenu.html | Test timed out.
> function runTest(testNum) {
>   // Seems we need to enable this again, or sendKeyEvent() complaints.
>   netscape.security.PrivilegeManager.enablePrivilege('UniversalXPConnect');
Firefox removed this enablePrivilege. However we still need this because we do:

> ("@mozilla.org/suite/shell-service;1" in Components.classes) ?
> ["context-setDesktopBackground", true] : []).concat(

Passed: 1713
Failed: 0
Todo: 0
Attachment #659722 - Flags: review?(sgautherie.bz)
Attachment #659722 - Flags: feedback?(neil)
Attachment #659722 - Flags: feedback?(neil) → feedback+
Comment on attachment 659722 [details] [diff] [review]
Patch v1.0 Proposed fix.

Serge seems to be MIA. Asking Neil for review. Whoever gets to this first.
Attachment #659722 - Flags: review?(neil)
Changes from Bug 792036 - Prepare test suite for disappearance of |Components| in content scopes.
Automated fixups: https://hg.mozilla.org/mozilla-central/rev/1f7c4fae49c0

***This applies on top of the test changes in Bug 715410.***
Attachment #664471 - Flags: review?(sgautherie.bz)
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/80da40ae69be
http://hg.mozilla.org/comm-central/rev/68361e51699b
rs=me test bustage.
post landing reviews pending.
Ugh still stopped at:

Timestamp: 30/09/12 12:33:26 AM
Error: TypeError: invalid 'in' operand SpecialPowers.Components.classes
Source File: http://mochi.test:8888/tests/suite/browser/test/test_contextmenu.html?autorun=1&closeWhenDone=1&logFile=c%3A%5Ct1%5Chg%5Cobjdir-sm%5Cmozilla%5Cmochitest-plain.log&fileLevel=INFO&consoleLevel=INFO&failureFile=c:\t1\hg\objdir-sm\mozilla\_tests\testing\mochitest\makefailures.json
Line: 336

Which is:

("@mozilla.org/suite/shell-service;1" in SpecialPowers.Components.classes) ?
Bug 789954 Part 3 followup to v2.0 more bustage SpecialPowers fix rs=me bustage fix post-landing review pending.

The V2.0 patch didn't fix the hang due to me doing a braino. This one works locally.

For some reason:
  SpecialPowers.Components.classes
Doesn't work but the following does"
  SpecialPowers.Cc

Passed: 1866
Failed: 0
Todo: 0
Attachment #666228 - Flags: review?(sgautherie.bz)
Pushed part 3. Leave open for post landing review.

http://hg.mozilla.org/comm-central/rev/3f9bea669835
Comment on attachment 659722 [details] [diff] [review]
Patch v1.0 Proposed fix.

> function executeCopyCommand(command, expectedValue)
> {
>   // Just execute the command directly rather than simulating a context menu
>   // press to avoid having to deal with its asynchronous nature
>-  subwindow.controllers.getControllerForCommand(command).doCommand(command);
>+  SpecialPowers.wrap(subwindow).controllers.getControllerForCommand(command).doCommand(command);
Maybe this should use chromeWin instead of SpecialPowers.wrap(subwindow)

>+    chromeWin = SpecialPowers.wrap(subwindow)
>                     .QueryInterface(Ci.nsIInterfaceRequestor)
>                     .getInterface(Ci.nsIWebNavigation)
>                     .QueryInterface(Ci.nsIDocShellTreeItem)
>                     .rootTreeItem
>                     .QueryInterface(Ci.nsIInterfaceRequestor)
>                     .getInterface(Ci.nsIDOMWindow)
>                     .QueryInterface(Ci.nsIDOMChromeWindow);
Nit: indentation
Attachment #659722 - Flags: review?(neil) → review+
Comment on attachment 666228 [details] [diff] [review]
Patch v3.0 Really fix the test this time.

>-    is(contextMenu.state, "closed", "checking if popup is closed");
>+    is(SpecialPowers.wrap(contextMenu).state, "closed", "checking if popup is closed");
[Odd. Isn't the context menu already wrapped? After all, it's a chrome element.]
Attachment #666228 - Flags: feedback+
Ugh, time to close this bug. rs=me
Attachment #659722 - Flags: review?(sgautherie.bz)
Comment on attachment 664471 [details] [diff] [review]
Patch v2.0 Additional changes from |Bug 792036 - Automated fixups|

rs=me
Attachment #664471 - Flags: review?(sgautherie.bz) → review+
Comment on attachment 666228 [details] [diff] [review]
Patch v3.0 Really fix the test this time.

rs=me
Attachment #666228 - Flags: review?(sgautherie.bz) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.15
You need to log in before you can comment on or make changes to this bug.