79003 - DnD bookmarks from personl toolbar popupmenus lock up UI on Linux

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Peter Snyder]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.4 i686; en-US; rv:0.9+) Gecko/20010504
BuildID:    2001050408

I have a folder of bookmarks in my toolbar.  When I open up one folder and begin
to drag a bookmark, mozilla freezes up for a long time (between 30 sec -
indefinatly).  Animating images still play in the browser, just X seems to
freeze up.  Pressing ALT and moving the mouse seems to fix it.

Reproducible: Always
Steps to Reproduce:
1. Open up a folder of bookmarks in the toolbar
2. Drag a bookmark.
3. Wait....
4. Press ALT and move the mouse to stop freeze

Actual Results:  X and Mozilla freeze until ALT is pressed

Comment 1

[Peter Snyder]

Just retested in official 9.0 release.  It still occours.  In addition, sawing
that it freezes X probably wasn't totally acurate.  What I mean is that
a) your curser is frozen as if you were dragging the bookmark, even if you let
the button go and move the curser else where
b) Clicks on anything else (in mozilla and else where) have no effect)

Weird hun.

Comment 2

[Peter Snyder]

Still here in 2001053021.  Changing to Blocker because my sister triggered this
bug on my computer, and felt the only way to resolve the problem was to reboot
the system.  I can't say I fault her for this, since I don't think many would
try holding alt and dragging the mouse as a fix.  This cannot be in a finished
product!  People shouldn't have to reboot because of their browser.  Thats why i
switched to Linux in the first place.

Comment 3

[Claudius Gayle]

Peter, please explain in excrutiating detail what it is you are doing.
Are you referring to the bookmarks menubutton on the ptoolbar or do you have
your own separate folder full of bookmarks on your ptoolbar?
Are you trying to drag the folder when it's open or are you trying to drag an item
that is visible when the folder is open? It's all in the details, please provide
them so i can have a chance at reproducing this bug and get it on the road to
being fixed if it is reproducible bug.

Comment 4

[Peter Snyder]

I have a seperate folder of bookmarks in the ptoolbar.  When I say drag, I mean
I click once on the folder to open it so it displays a set of bookmarks.  Then,
i click and hold on one of the displayed bookmarks.  If i then drag the mouse, I
get the GNOME "piece of paper icon", as if I were dragging the bookmark (the
windows equivilent is a small box outlined by a simi-transparent line, as if you
were selecting multiple icons on the desktop).  The "piece of paper icon" stays
right where I clicked on the bookmark.  My arrow curser is replaced with what
looks like a + sign, but with a border on the top and right sides, so it looks
like this (sorta)

 --------
|   | |
|---------
|---------
|   | |  
       
It remains like this, seeming to ignore all mouse clicks and keyboard input,
although I can continue to move the curser around the screen.  Images in mozilla
contine to animate, as well as the rest of the desktop (ie music still plays,
the clock contines to count, etc...), just you cannot interact with it.  This
continues until either esc or alt are pressed (the two buttons that collapse the
folder from the keyboard), afterwhich the arrow curser returns, with the GNOME
paper icon attached to it.  Everything is normal then.  This does not accour in
Windows mozilla.
Well, thats about as specific as I can get.  If you have any questions, feel
free to ask.

Comment 5

[Claudius Gayle]

Confirmed with 2001053108 builds. I'm not sure what the hell is going on here
but I'll nontheless try to explain:
As it turns out, although I didn't know, one can DragNDrop willy-nilly to/from
XPpopupmenus. I thought that ability was turned off but I guess I'm wrong.

Anyway, on Linux only when you try to drag an item away from a popupmenu things
get screwy and you appear to lock up. It turns out of you just press 'ESC', you
get UI control back AND you can finish your drop gesture - you just have to wait
for the two peices of the cursor to catch back up to each other!

To repro:
0. You need to have the bookmarks button 'on' or a real folder(not extended
data) on your personal toolbar.
1. Click to pop open the folder
2. click+hold a bookmark that isn't already on your ptoolbar
3. Try to drag to your ptoolbar (anywhere really)
4. Press 'Esc' when things get screwy.
5. Amazingly you can now still finish your drop.

I think this bug is a toolkit bug, pink? Linux ONLY

Comment 6

[Claudius Gayle]

i seem to remember chris dabbling with Linux DnD...

Comment 7

[Mike Pinkerton (not reading bugmail)]

if it's linux only, it sounds like we're doing some server grabs during the
xpmenus that is interfering with drag/drop.

personally, i don't know why dragging from these popups is allowed (*glares at
ben*) and i would recommend turning it off as soon as humanly possible. No one
will ever miss this "feature".

Comment 8

[Claudius Gayle]

In Ben's defense I'd imagine this would have to work(still shocked that it does
on Mac and Win) in order to get the slick "drag url's to exactly where you want
them to bookmark them" quickfile feature everybody (except Mac 4.x users who
never knew it even existed- but i'm not bitter, really) has been bitching about.

Comment 9

[Claudius Gayle]

In Ben's defense I'd imagine this would have to work(still shocked that it does
on Mac and Win) in order to get the slick "drag url's to exactly where you want
them to bookmark them" quickfile feature everybody (except Mac 4.x users who
never knew it even existed- but i'm not bitter, really) has been bitching about.

Comment 10

[Viswanath Ramachandran]

nav+pdt triage: not a rtm stopper. nice to have this. moving to mozilla0.9.3. 
just turning off the ability to drag from the popupmenu would be acceptable for 
this release so that it doesnt lock up the UI. 

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Disagree. Hang, fairly easy to reproduce, hangs X. Requires Ctrl+Alt+Escape'ing 
X server. Recent builds show subsequent crash. 

Fix is trivial. Patch coming shortly. 

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to fix

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

2 line fix (+ comments)

Prevent dragging out of non-button items in the personal toolbar if the platform 
isn't Windows. (See comment in diff for more info). 

Comment 14

[Blake Ross]

sr=blake

Comment 15

[Mike Pinkerton (not reading bugmail)]

i protest, but i'll be overruled.

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

What pink means to say is that he thinks this should be disabled everywhere, 
because as a Mac user, he believes dragging from menus is satanic and wrong. 

That may be, but for windows users accustomed to IE, the ability to drag out of 
menus is a feature of the OS. As the functionality works on Windows without 
hangs or crashes, I'm choosing to keep it working there. 

I told hyatt about this fix, and he approved of it. 

Comment 17

[Christopher Blizzard (:blizzard)]

I like this feature and I wish that I had it on linux.  I suspect that I could
fix it, given the chance.  Ben, can you open another tracking bug for that
feature with a reference to this bug before you check in, please?

Comment 18

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. 

Comment 20

[Claudius Gayle]

whoa, what the hell, how'd this get past 17 reviewers and whatnot? Although this is an abomination
on Mac like Pink says - it DOES work. Please don't start screwing Mac again with features only
implemented on Windows(XPFE anyone?). This is the same exact feature that I didn't know existed
in Communicator 4.x cuz I was using a Mac. Now we have it on Mac and you wanna take it away again?

AND this mostly works on linux. read my comments - i am a professional tester and everything :-)

there's no force quiting and restarting X or any crazy crap like that necessary. all you have to do is
press 'Esc' AND you can still finish your DnD - it works.

reopening out of sheer shock and amazement

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

Claudius - 

as far as I can tell the bug described here has been fixed. 

1) A new bug has been filed on the D&D issue on linux. Blizzard wants a chance
to fix it.
2) If you want this feature re-enabled on mac, you're going to have to
mud-wrestle pink (I suspect you'll win, however ;). Anyhow, open a new bug with
an appropriate summary. 

Comment 22

[Claudius Gayle]

I don't get it. This bug was nsbeta1+'d but you only checked it into the trunk. So what happens
now?

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Well, Vishy shifted it out of beta1. I fixed it when I fixed it because I 
thought it was a serious issue that needed attention for RTM.

BTW: I'm not against this feature (if I was, I'd have disabled it across all 
platforms) - I disabled for Mac too because of his repeated claims that "no one 
would be dragging items out of menus on [his] watch". However, maybe we can 
twist his arm ;) 

Comment 24

[Paul Chen]

If there are any other issue still standing, please log seperate bugs. So if this 
is checked into the trunk, it will get picked up when mozilla0.9.2 is branched, 
right? Marking fixed

Comment 25

[timeless]

*** Bug 84322 has been marked as a duplicate of this bug. ***

Comment 26

[Claudius Gayle]

so it's cool to remove the 'nsbeta1+' then? In effect saying this isn't going to be in the beta
and only needs to be checked in and verified on the trunk?

I'm not arguing here, just tidying up. I can't very well mark and nsbeta1+ bug as 'VERIFIED'
if it's not on the branch.

clearing nsbeta1+ someone speakup if that's wrong.

Comment 27

[Claudius Gayle]

just to sum up, this works on Windows and Mac and 90% on Linux. This bug has successfully
managed to turn it off for mac and Linux. vox clamantis in deserto.

VERIFIED Fixed.