790093 - Unnecessary const_cast in the nsGfxButtonControlFrame.cpp

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Arnaud Bienner]

Attachment: removeConstCast.patch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:15.0) Gecko/20100101 Firefox/15.0
Build ID: 20120825192204

Steps to reproduce:

Not a real "bug", and very minor thing, but I saw this when working on bug 547004 for implementing input color, and it bothers me.
But as it's not related directly, I'm opening this bug, as suggested.

There is an unnecessary const_cast in the nsGfxButtonControlFrame.cpp
I don't know if it was needed one day (it was added before Hg migration), but I'm quite sure it's not necessary today.

I know it's better (from a design point of view) to avoid const_cast, and also that this might help the compiler in some (very few) cases to optimize the code.
But only the fact that it makes the code nicer is enough to change this IMHO.


Actual results:

const_cast


Expected results:

no const_cast

Comment 1

[Mounir Lamouri (:mounir)]

Sent to try:
https://tbpl.mozilla.org/?tree=Try&rev=54bed0a9a320

Comment 2

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9615e179825

Comment 3

[Arnaud Bienner]

I think we can close this bug, right?
Unfortunately I'm not allowed to choose FIXED in the status (only RESOLVED and then INVALID, etc.) :(

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Arnaud from comment #3)
> I think we can close this bug, right?
> Unfortunately I'm not allowed to choose FIXED in the status (only RESOLVED
> and then INVALID, etc.) :(

No, this bug will be marked as RESOLVED FIXED when it will be pushed to mozilla-central. It's right now it mozilla-inbound which is some kind of baking repository that is used to make sure we don't push broken stuff on mozilla-central.

Comment 5

[Arnaud Bienner]

Oh! OK: I didn't thought about that.
Thanks for the clarification ;)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e9615e179825