790123 - CSS2PropertiesBinding.h:141:1: warning: no newline at end of file [-pedantic,-Wnewline-eof]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mats Palmgren (inactive)]

clang++ complains:
../../../../dist/include/mozilla/dom/CSS2PropertiesBinding.h:141:1: warning: no newline at end of file [-pedantic,-Wnewline-eof]

clang version 3.1 (trunk 152341)

Comment 1

[Boris Zbarsky [:bzbarsky]]

This applies to all the generated binding headers, right?

The problem is that we run the overall text through this:

  def stripTrailingWhitespace(text):
    lines = text.splitlines()
    for i in range(len(lines)):
        lines[i] = lines[i].rstrip()
    return '\n'.join(lines)

Patch coming up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure to not lose a single trailing newline in stripTrailingWhitespace.

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 660075 [details] [diff] [review]
Make sure to not lose a single trailing newline in stripTrailingWhitespace.

Seems like this is bound to happen sooner or later:

>>> stripTrailingWhitespace('')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 2, in stripTrailingWhitespace
IndexError: string index out of range

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: OK, how about something like this, then?

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 660139 [details] [diff] [review]
OK, how about something like this, then?

Looks good, thanks.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3254e5b70c09

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3254e5b70c09