790167 - SeaMonkey 2.12.1 update is broken

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Download SeaMonkey 2.12
2. Try to update to SeaMonkey 2.12.1 with integrated update function

Results:
SeaMonkey 2.12 first downloads the incremental update and then says:
"SeaMonkey was unable to verify the integrity of the incremental update it downloaded, so it is now downloading the complete update package."

After downloading the complete package I get:
"The integrity of the update could not be verified"

I suggest we disable the in-app update for now until this is fixed (if possible).

Comment 1

[Justin Wood (:Callek)]

Can I see someones last-update.log from the 2.12->2.12.1 and what hash are you getting on the partial mar?

version=1
type=partial
url=http://download.mozilla.org/?product=seamonkey-2.12.1-partial-2.12&os=win&lang=en-US
hashFunction=SHA512
hashValue=f76a5405c58a26cb9bb6f167259b0e48e0719b68636967eb5f957757c683c8f7db54363688174d6ec0878ba47abf99cca6e79e
3a56d972ef2b070c1ba8edd40
size=1669765
build=20120909051100
appv=2.12.1
extv=2.12.1
detailsUrl=http://www.seamonkey-project.org/releases/seamonkey2.12.1/

Comment 2

[Justin Wood (:Callek)]

hashValue=f76a5405c58a26cb9bb6f167259b0e48e0719b68636967eb5f957757c683c8f7db54363688174d6ec0878bab47abf99cca6e79e3a56d972ef2b070c1ba8edd40

... err misplaced my cursor when I hit backspace on last comment, correct hash is here ^

Comment 3

[Tony Mechelynck [:tonymec]]

In reply to comment #1:
Frank, apparently you saw this on W32. AFAICT it was also described in bug 789826 comment #2 by a Linux-i386 user. OTOH I tried to reproduce it on linux-x86_64 and got no error; I even checked for updates and it told me "There are no updates available" so I'm leaving "Hardware" at i386 (for now at least) and setting OS to All.

Comment 4

[Frank Wein [:mcsmurf]]

(In reply to Justin Wood (:Callek) from comment #1)
> Can I see someones last-update.log from the 2.12->2.12.1 and what hash are
> you getting on the partial mar?

I see no last-update.log in the Local Settings\Appdata\Mozilla\SeaMonkey\seamonkey folder. I can only provide an update.xml file and an active-update.xml file.

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: updates.xml

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: active-update.xml

Comment 7

[Frank Wein [:mcsmurf]]

I don't know why updates.xml says "state="download-failed" for both files. I checked with Wireshark, my PC seems to receive the whole .mar file after starting the update process (hash is identical to the one you posted). So not sure why SeaMonkey stops(?) the download a few bytes before it is finished. Or is this not the real issue?

Comment 8

[Justin Wood (:Callek)]

Possibly related to Bug 789958 ?

Comment 9

[Frank Wein [:mcsmurf]]

Attachment: Log from the error console with app.update.log=true

Comment 10

[Frank Wein [:mcsmurf]]

The problem seems to be indicated by this code:
     // Ensure that the file size matches the expected file size.
     if (destination.fileSize != this._patch.size)
       return false;

Vars are:
destination.fileSize 1669765
this._patch.size 1668574

I wonder if this._patch is not updated correctly when the file transfer stops.

Comment 11

[Frank Wein [:mcsmurf]]

I think I found the problem:
https://aus2-community.mozilla.org/update/3/SeaMonkey/2.12/20120826214753/WINNT_x86-msvc/en-US/release/Windows_NT%205.1.3.0%20%28x86%29/default/default/update.xml?force=1
<patch type="complete" URL="http://download.mozilla.org/?product=seamonkey-2.12.1-complete&os=win&lang=en-US&force=1" hashFunction="SHA512" hashValue="e69f416ff4c91c803a66c8a8177da89de3d89eb7e5963879163e0ddbb5b8d7ad3a8095b34fbc56b567fa598ad6f5cc027b97510108f8d5044ebf33f129948c15" size="24381004"/><patch type="partial" URL="http://download.mozilla.org/?product=seamonkey-2.12.1-partial-2.12&os=win&lang=en-US&force=1" hashFunction="SHA512" hashValue="b6f5245036a4c63625b84e2a89775ba50bed5d25d47f8bf76def5c9f93baea1ca80f42c1cc5011d650e3da3c7c5d58bd3a9612fc691852c75e561f778ea219c1" size="1668574"/>

The size for the partial (and also the complete) patch is different from the .mar file that gets downloaded.

Comment 12

[Edmund Wong (:ewong)]

This is entirely my fault.  

I pushed build1 and not build2. 

Fixing this right now.

Comment 13

[Frank Wein [:mcsmurf]]

Update works fine now on Windows. Maybe someone else can check Linux and OS X.

I think the installer on seamonkey-project.org (at least for Windows) was already the correct build. It displayed as version 2.12.1 and a diff tool did not show any differences between the updated SeaMonkey 2.12->2.12.1 and the Windows installer build from seamonkey-project.org

Comment 14

[Jan Hoogenraad]

I had a problem on linux 2.11 -> 2.12.1. The new build corrects it. Thanks.

Comment 15

[Frank Wein [:mcsmurf]]

This bug looks fixed then.