790183 - Sending unnecessary IPC message during cross-process touch event dispatch

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

See bug 780341 comment 16.  We don't care about PBrowser:ContentReceivedTouch except for async pan/zoomed content (when an apzc may be involved).

Without the simple fix, with bug 788943 applied, the homescreen panning framerate hits 35-37 fps (dipping down because of bug 789664).

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

With the fix, framerate seems to *drop* to 33-35 fps.  Iiiinteresting.  Will confirm that this write() disappears from profiles in a bit.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

The simple patch doesn't make the write() go away (which in retrospect makes sense, since we're already in ViewManager!), so the source is something else.

http://people.mozilla.com/~bgirard/cleopatra/?report=94b0219c17e2d4f87c1fd966dddd78fe85d3a8d7

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Don't send SetCursor if the cursor hasn't changed

Profile after this patch

http://people.mozilla.com/~bgirard/cleopatra/?report=9b48099b1f39f9d3ed5df9bc5c6a272ddb928bb2

The unnecessary IPC traffic is gone.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5700bc77ea5

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a5700bc77ea5