Closed Bug 790247 Opened 12 years ago Closed 12 years ago

reflect.parse "word with space" Identifiers aren't computed.

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: glind, Unassigned)

References

Details

Attachments

(1 file)

      No description provided.
"computed" should be true in the following.

js> print(JSON.stringify(Reflect.parse('var a = {}; a["some thing"] = 1'),null,2))


{loc:{start:{line:1, column:0}, end:{line:1, column:15}, source:null}, type:"MemberExpression", object:{loc:{start:{line:1, column:0}, end:{line:1, column:1}, source:null}, type:"Identifier", name:"a"}, property:{loc:null, type:"Identifier", name:"some thing"}, computed:false}




https://gist.github.com/3694575
https://github.com/Constellation/escodegen/issues/52
Surpress computed property name folding
Attachment #660132 - Flags: review?(jorendorff)
Comment on attachment 660132 [details] [diff] [review]
v1. Not folding property name

Review of attachment 660132 [details] [diff] [review]:
-----------------------------------------------------------------

Love it!
Attachment #660132 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/a48425deb532
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: