790261 - Avoid the profiler misbehaving randomly when mozilla_sampler_start is given impossible values

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Mike Hommey [:glandium]]

When the entry size given to TableTicker is 0, desktop crashes with SIGFPE, but on mobile, SIGFPE is apparently caught by the soft-float code, and in the end, not only does it not crash, but the profiler ends up doing random stuff. I suspect an interval of 0 to have possible problems, too.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid the profiler misbehaving randomly when mozilla_sampler_start is given impossible values

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe96a330ddd8

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fe96a330ddd8