Closed Bug 790261 Opened 8 years ago Closed 8 years ago

Avoid the profiler misbehaving randomly when mozilla_sampler_start is given impossible values

Categories

(Core :: Gecko Profiler, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

When the entry size given to TableTicker is 0, desktop crashes with SIGFPE, but on mobile, SIGFPE is apparently caught by the soft-float code, and in the end, not only does it not crash, but the profiler ends up doing random stuff. I suspect an interval of 0 to have possible problems, too.
Attachment #660095 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/fe96a330ddd8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.