Closed
Bug 790294
Opened 13 years ago
Closed 13 years ago
GCLI screenshot command should show preview.
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 18
People
(Reporter: Optimizer, Assigned: Optimizer)
References
Details
Attachments
(1 file, 2 obsolete files)
1.04 KB,
patch
|
Optimizer
:
review+
|
Details | Diff | Splinter Review |
It would be nice if the image save to the file would be visible as preview along the text indicating the same.
Attachment #660128 -
Flags: review?(jwalker)
Comment 1•13 years ago
|
||
Comment on attachment 660128 [details] [diff] [review]
patch v1.0
Review of attachment 660128 [details] [diff] [review]:
-----------------------------------------------------------------
r+ with one change.
Thanks for this patch - it's a nice touch that will make people go 'oooh'.
::: browser/devtools/commandline/CmdScreenshot.jsm
@@ +220,5 @@
> + "min-height:" + previewHeight + "px !important;" +
> + "height:" + previewHeight + "px !important;" +
> + "background-image: url('" + data + "') !important;" +
> + "background-size: 256px " + previewHeight + "px !important;" +
> + "margin: 4px !important; display: block !important");
I don't think we should need all the '!important's. The specificity of an element's style node should make it win against all.
Attachment #660128 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Joe Walker [:jwalker] from comment #1)
> I don't think we should need all the '!important's. The specificity of an
> element's style node should make it win against all.
Actually, without the !important s, the style was not getting applied on the image. I also don't want so much !important s. I will see what all can I get rid of.
Assignee | ||
Comment 3•13 years ago
|
||
Ready for try.
Attachment #660128 -
Attachment is obsolete: true
Attachment #660469 -
Flags: review+
Comment 4•13 years ago
|
||
Comment on attachment 660469 [details] [diff] [review]
remove !important
Review of attachment 660469 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/devtools/commandline/CmdScreenshot.jsm
@@ +219,5 @@
> div.style.cursor = "pointer";
> + let image = document.createElement("div");
> + let previewHeight = parseInt(256*height/width);
> + image.setAttribute("style",
> + "max-width:256px; min-width:256px;" +
Just curious here, why set max-width and min-width and not just width?
@@ +222,5 @@
> + image.setAttribute("style",
> + "max-width:256px; min-width:256px;" +
> + "max-height:" + previewHeight + "px;" +
> + "min-height:" + previewHeight + "px;" +
> + "height:" + previewHeight + "px;" +
max-height and min-height and height?
Assignee | ||
Comment 5•13 years ago
|
||
Ready to land :)
Attachment #660469 -
Attachment is obsolete: true
Attachment #660986 -
Flags: review+
Assignee | ||
Comment 6•13 years ago
|
||
Whiteboard: [land-in-fx-team]
Comment 7•13 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 18
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•