Closed Bug 790344 Opened 9 years ago Closed 9 years ago

"Error in worker: Exception: TypeError: url.startsWith is not a function" in Firefox < 17

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: florian, Unassigned)

References

()

Details

I've profiled a performance issue in Thunderbird, unfortunately the uploaded profile cannot be displayed, instead I see a JS error:

Error in worker: Exception: TypeError: url.startsWith is not a function (http://people.mozilla.com/~bgirard/cleopatra/js/parserWorker.js:263) 

Locally the profiler works fine.

I could upload profiles successfully with almost the same version of the profiler on a Firefox nightly. For Thunderbird I applied the fix from bug 769483 because otherwise most of the time is spent throwing JS errors (I'm creating thousands of DOM documents with DOMParser.parseFromString in the code that I'm profiling).
So, should we just rebuild the add-on extension with a new add-on SDK to get this fix deployed?
Isn't this a cleopatra bug, not one of the extension?
I introduced the url.startsWith line yesterday in https://github.com/bgirard/cleopatra/commit/9221eb539e7f7cc1605f7bd0962d4a1c4c80ad54
I think we only need to make parseResourceName null-safe and redeploy http://people.mozilla.com/~bgirard/cleopatra/ or am I missing anything?
Oh, I think I know what I'm missing. Florian, which Firefox version did you use to view your profile? Because it works in my Firefox (Nightly). So I guess String.prototype.startsWith was only added recently?
(In reply to Markus Stange from comment #3)
> Oh, I think I know what I'm missing. Florian, which Firefox version did you
> use to view your profile? Because it works in my Firefox (Nightly). So I
> guess String.prototype.startsWith was only added recently?

It works in my nightly (great!). I was using 15.0.
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> So, should we just rebuild the add-on extension with a new add-on SDK to get
> this fix deployed?

I think this would be a good idea to avoid the issue I mentioned in bug 720261 comment 3, but it turns out this isn't directly related to the error I was reporting here, as using a Nightly to view the profile works.
And it's deployed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Cannot display online a profile with null URLs → "Error in worker: Exception: TypeError: url.startsWith is not a function" in Firefox < 17
You need to log in before you can comment on or make changes to this bug.