add more profile labels for style change processing

RESOLVED FIXED in mozilla18

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla18
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
See bug 780341 and bug 779968 for background.

Looking at profiles for style change processing is somewhat confusing right now; the stuff currently inside the CSS::ProcessRestyles label is really two different things, recomputation of style data and then handling the resulting changes.

This patch adds two labels to split it into those major parts.  It's untested.
(Assignee)

Comment 1

6 years ago
Created attachment 660194 [details] [diff] [review]
Add more profile labels for the separate parts of restyle processing.  ()
Attachment #660194 - Flags: review?(jones.chris.g)
Comment on attachment 660194 [details] [diff] [review]
Add more profile labels for the separate parts of restyle processing.  ()

rs=me
Attachment #660194 - Flags: review?(jones.chris.g) → review+

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/557733e500ca
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(Assignee)

Comment 5

6 years ago
Created attachment 660585 [details] [diff] [review]
two more labels

Two more labels, to try to distinguish benefits we'd get from bug 780341 comment 30 (would help with the time inside FileRules) vs. benefits we'd get from bug 780341 comment 38 (would help with the time inside CalcStyleDifference).

With these labels, I'm a bit concerned that they're too far inside the loop and might influence the timing.  However, I *think* they're going to occur the same number of times in the cases we're looking at, since we won't actually end up with the same style context in any of the cases where we hit FileRules.
Attachment #660585 - Flags: review?(jones.chris.g)
Comment on attachment 660585 [details] [diff] [review]
two more labels

rs=me (rubberstamp because I don't know this code and am trusting you to put them in the right place.)  You're more than welcome to land any more labels you want to add as rs=me, too.
Attachment #660585 - Flags: review?(jones.chris.g) → review+
You need to log in before you can comment on or make changes to this bug.