Closed Bug 790381 Opened 7 years ago Closed 7 years ago

Update libopus to 1.0.0 release

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(3 files, 2 obsolete files)

Version 1.0.0 of the opus audio codec reference implementation, corresponding to RFC 6716, was released today. We should update our in-tree copy to have that milestone as a reference point.
My update.sh needs a fix to parse the source file lists properly.
Assignee: nobody → giles
Attachment #660198 - Flags: review?(tterribe)
Attached patch libopus update (obsolete) — Splinter Review
Patch to update our in-tree opus to the 1.0.0 release.
Attached patch multistream include fix (obsolete) — Splinter Review
Remove the extern "C" { #include "opus_multistream.h" } work-around needed for bug 748144, which is no longer necessary.
Attachment #660208 - Flags: review?(tterribe)
Comment on attachment 660202 [details] [diff] [review]
libopus update

Pushed the stack to try as https://tbpl.mozilla.org/?tree=Try&rev=7dfc674a6d48
Attachment #660202 - Flags: review?(tterribe)
Blocks: 790405
Attachment #660208 - Flags: review?(tterribe) → review+
Comment on attachment 660202 [details] [diff] [review]
libopus update

Review of attachment 660202 [details] [diff] [review]:
-----------------------------------------------------------------

The only code changes since draft-12 that aren't whitespace or copyright notice updates are the extern "C" thing and a bump of the struct alignment from 4 bytes to sizeof(void *), so this should be pretty safe.
Attachment #660202 - Flags: review?(tterribe) → review+
Attachment #660198 - Flags: review?(tterribe) → review+
Attached patch libopus updateSplinter Review
Thanks for the review. Updating the patch with an ammended commit message to mention the alignment change. Carrying forward r+.
Attachment #660202 - Attachment is obsolete: true
Attachment #660231 - Flags: review+
Re-attaching the same multistream fix patch to keep the order correct. Carrying forward the r+.
Attachment #660208 - Attachment is obsolete: true
Attachment #660232 - Flags: review+
Try push looks green. Please apply all three patches, in the order listed.
Keywords: checkin-needed
This is covered by existing tests.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.