Closed
Bug 790381
Opened 12 years ago
Closed 12 years ago
Update libopus to 1.0.0 release
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla18
People
(Reporter: rillian, Assigned: rillian)
References
Details
Attachments
(3 files, 2 obsolete files)
|
1.69 KB,
patch
|
derf
:
review+
|
Details | Diff | Splinter Review |
|
327.84 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
|
1.12 KB,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
Version 1.0.0 of the opus audio codec reference implementation, corresponding to RFC 6716, was released today. We should update our in-tree copy to have that milestone as a reference point.
|
Assignee | |
Comment 1•12 years ago
|
||
My update.sh needs a fix to parse the source file lists properly.
Assignee: nobody → giles
Attachment #660198 -
Flags: review?(tterribe)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Patch to update our in-tree opus to the 1.0.0 release.
|
|
Assignee | |
Comment 3•12 years ago
|
||
Remove the extern "C" { #include "opus_multistream.h" } work-around needed for bug 748144, which is no longer necessary.
Attachment #660208 -
Flags: review?(tterribe)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 660202 [details] [diff] [review] libopus update Pushed the stack to try as https://tbpl.mozilla.org/?tree=Try&rev=7dfc674a6d48
Attachment #660202 -
Flags: review?(tterribe)
|
||
Updated•12 years ago
|
Attachment #660208 -
Flags: review?(tterribe) → review+
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 660202 [details] [diff] [review] libopus update Review of attachment 660202 [details] [diff] [review]: ----------------------------------------------------------------- The only code changes since draft-12 that aren't whitespace or copyright notice updates are the extern "C" thing and a bump of the struct alignment from 4 bytes to sizeof(void *), so this should be pretty safe.
Attachment #660202 -
Flags: review?(tterribe) → review+
|
|
||
Updated•12 years ago
|
Attachment #660198 -
Flags: review?(tterribe) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
Thanks for the review. Updating the patch with an ammended commit message to mention the alignment change. Carrying forward r+.
Attachment #660202 -
Attachment is obsolete: true
Attachment #660231 -
Flags: review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
Re-attaching the same multistream fix patch to keep the order correct. Carrying forward the r+.
Attachment #660208 -
Attachment is obsolete: true
Attachment #660232 -
Flags: review+
|
|
Assignee | |
Comment 8•12 years ago
|
||
Try push looks green. Please apply all three patches, in the order listed.
Keywords: checkin-needed
|
||
Comment 9•12 years ago
|
||
(In reply to Ralph Giles (:rillian) from comment #4) > https://tbpl.mozilla.org/?tree=Try&rev=7dfc674a6d48 Green on Try. https://hg.mozilla.org/integration/mozilla-inbound/rev/b1043cd9de87 https://hg.mozilla.org/integration/mozilla-inbound/rev/fd83eb48a437 https://hg.mozilla.org/integration/mozilla-inbound/rev/f00973c233e8 Is this covered by existing tests?
Flags: in-testsuite?
Keywords: checkin-needed
|
|
Assignee | |
Comment 10•12 years ago
|
||
This is covered by existing tests.
Flags: in-testsuite? → in-testsuite+
|
|
||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b1043cd9de87 https://hg.mozilla.org/mozilla-central/rev/fd83eb48a437 https://hg.mozilla.org/mozilla-central/rev/f00973c233e8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in
before you can comment on or make changes to this bug.
Description
•