790395 - error: api-utils: TEST FAILED: test-content-proxy.testCrossDomainIframe (failure)

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm seeing this test failure now with every run on inbound when https://hg.mozilla.org/integration/mozilla-inbound/rev/634a2b9859ab landed.

error: api-utils: TEST FAILED: test-content-proxy.testCrossDomainIframe (failure)
error: api-utils: fail: COW fails : Permission denied to access property 'toString'
++DOMWINDOW == 37 (0x12eb3d970) [serial = 37] [outer = 0x12c0dddc0]
WARNING: Unable to test style tree integrity -- no content node: file ../../../layout/base/nsCSSFrameConstructor.cpp, line 8209
info: api-utils: Traceback (most recent call last):
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/timer.js", line 28, in notify
    callback.apply(null, args);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 100, in null
    self._emit.apply(self, JSON.parse(args));
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 119, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 149, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 215, in portEmit
    self._addonWorker._onContentScriptEvent.apply(self._addonWorker, arguments);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/content/worker.js", line 513, in _onContentScriptEvent
    this._port._emit.apply(this._port, arguments);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 119, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/events.js", line 149, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/tests/test-content-proxy.js", line 84, in null
    test.assert(data.assertion, data.msg);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/unit-test.js", line 133, in assert
    this.fail(message);
  File "resource://f7656465-978b-47d8-80a4-5cb65410518c-at-jetpack/api-utils/lib/unit-test.js", line 71, in fail
    this.console.trace();

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 567

The cross domain test was quite limited and didn't reflected any real usecase.
But there is some real usecase where a content script want to do something with an iframe on another domain, like passing messages. And we need to ensure that it works correctly in content scripts.

I've improved this test to test this and avoid any unsafe or non-standard practices like String(...).

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/77b1987c9608acc628f9e641c3c796167d5fcc93
Bug 790395: Improve cross domain content script unit test with a real usecase.

https://github.com/mozilla/addon-sdk/commit/321667ea33ea20fef9f4c7a0c2d03dd5ea29d5d8
Merge pull request #567 from ochameau/bug/790395

Bug 790395: Improve cross domain content script unit test with a real usecase. r=@erikvold

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reopening so we can track the push I just made to inbound in https://hg.mozilla.org/integration/mozilla-inbound/rev/def643b50ef1 to get the fix over to mozilla-central.

Comment 6

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/def643b50ef1