Closed Bug 790561 Opened 8 years ago Closed 8 years ago

[TSF] Separate InsertTextAtSelection()

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(1 file)

nsTextStore::InterfaceTextAtSelection() is an interface method but it's called internally. And it's too big for a method. We should separate it.
Attached patch PatchSplinter Review
This patch depends on the patch for bug 789703.
Attachment #660713 - Flags: review?(jmathies)
Attachment #660713 - Flags: review?(jmathies) → review+
backed out due to found a mistake. (InsertTextAtSelection() doesn't return S_OK at the end of it)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a42f760fcf3
Whiteboard: [leave open]
relanded with the fix (return S_OK; at the end of InsertTextAtSelection()):
https://hg.mozilla.org/integration/mozilla-inbound/rev/440f587c464a
Whiteboard: [leave open] → [leave open] until 440f587c464a
https://hg.mozilla.org/mozilla-central/rev/440f587c464a

Our merge script recognizes backouts, so you don't need to put a [leave open] on in that situation. In fact, doing so made it more confusing for me as to whether this needed resolving or not!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [leave open] until 440f587c464a
You need to log in before you can comment on or make changes to this bug.