790561 - [TSF] Separate InsertTextAtSelection()

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

nsTextStore::InterfaceTextAtSelection() is an interface method but it's called internally. And it's too big for a method. We should separate it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

This patch depends on the patch for bug 789703.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a20a844caec

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

backed out due to found a mistake. (InsertTextAtSelection() doesn't return S_OK at the end of it)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a42f760fcf3

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

relanded with the fix (return S_OK; at the end of InsertTextAtSelection()):
https://hg.mozilla.org/integration/mozilla-inbound/rev/440f587c464a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/440f587c464a

Our merge script recognizes backouts, so you don't need to put a [leave open] on in that situation. In fact, doing so made it more confusing for me as to whether this needed resolving or not!