If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[TSF] Separate InsertTextAtSelection()

RESOLVED FIXED in mozilla18

Status

()

Core
Widget: Win32
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla18
x86_64
Windows 7
inputmethod
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsTextStore::InterfaceTextAtSelection() is an interface method but it's called internally. And it's too big for a method. We should separate it.
Created attachment 660713 [details] [diff] [review]
Patch

This patch depends on the patch for bug 789703.
Attachment #660713 - Flags: review?(jmathies)

Updated

5 years ago
Attachment #660713 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a20a844caec
Target Milestone: --- → mozilla18
backed out due to found a mistake. (InsertTextAtSelection() doesn't return S_OK at the end of it)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a42f760fcf3
Whiteboard: [leave open]
relanded with the fix (return S_OK; at the end of InsertTextAtSelection()):
https://hg.mozilla.org/integration/mozilla-inbound/rev/440f587c464a
Whiteboard: [leave open] → [leave open] until 440f587c464a
https://hg.mozilla.org/mozilla-central/rev/440f587c464a

Our merge script recognizes backouts, so you don't need to put a [leave open] on in that situation. In fact, doing so made it more confusing for me as to whether this needed resolving or not!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [leave open] until 440f587c464a
You need to log in before you can comment on or make changes to this bug.